Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd-opentracing-cpp: migrate to Conan v2 #18816

Merged
merged 11 commits into from
May 20, 2024
Merged

dd-opentracing-cpp: migrate to Conan v2 #18816

merged 11 commits into from
May 20, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

No description provided.

@ghost
Copy link

ghost commented Jul 22, 2023

I detected other pull requests that are modifying dd-opentracing-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jul 22, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Jul 22, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Jul 24, 2023
Closed
3 tasks
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@ghost ghost mentioned this pull request Oct 18, 2023
Closed
@AbrilRBS
Copy link
Member

The last grpc issue lost some PR jobs, I've retriggered them now

@valgur valgur mentioned this pull request Nov 8, 2023
Open
@mayeut mayeut mentioned this pull request Dec 3, 2023
Merged
3 tasks
uilianries
uilianries reviewed Apr 2, 2024
View reviewed changes
recipes/dd-opentracing-cpp/all/conanfile.py Outdated

def generate(self):
tc = CMakeToolchain(self)
if self.settings.compiler == "clang" and Version(self.settings.compiler.version) < "4.0":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still miss information, I see no relation in the upstream. Please, remove it.

recipes/dd-opentracing-cpp/all/patches/1.3.0/0001-Find-packages-setup.patch Outdated Show resolved Hide resolved
recipes/dd-opentracing-cpp/all/patches/1.3.0/0001-Find-packages-setup.patch Outdated Show resolved Hide resolved
valgur and others added 2 commits April 2, 2024 17:56
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/dd-opentracing-cpp branch from 91c546f to ed5c222 Compare April 3, 2024 09:46
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Hooks produced the following warnings for commit ed5c222
dd-opentracing-cpp/1.3.7@#af1b83338d57a09bc96c7e70fcc28d3b 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdd_opentracing.so' links to system library 'm' but it is not in cpp_info.system_libs.
dd-opentracing-cpp/1.3.0@#eaa46748bda8d8f956117963536d6043 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdd_opentracing.so' links to system library 'm' but it is not in cpp_info.system_libs.

danimtb
danimtb previously approved these changes Apr 25, 2024
View reviewed changes
@jjcasmar
Copy link
Contributor

Can this be merged? Or what is missing? I was about to write my own v2 recipe

AbrilRBS
AbrilRBS approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved some files around as a last minor change, looks great now, thanks a lot for your patience :)

uilianries
uilianries approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (aa2637ec79e879042d2a1d55a1e5aa6dab68ea3e):

  • dd-opentracing-cpp/1.3.7:
    All packages built successfully! (All logs)

  • dd-opentracing-cpp/1.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (aa2637ec79e879042d2a1d55a1e5aa6dab68ea3e):

  • dd-opentracing-cpp/1.3.7:
    All packages built successfully! (All logs)

  • dd-opentracing-cpp/1.3.0:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit aa2637e
dd-opentracing-cpp/1.3.7@#8dbf0f18cc621a7735f25e6fc987ff15 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdd_opentracing.so' links to system library 'm' but it is not in cpp_info.system_libs.
dd-opentracing-cpp/1.3.0@#8f7988e1b8e4fd1f8c8de50a1166c2f3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdd_opentracing.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 63c3ee8 into conan-io:master May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@DS-Alex-AG DS-Alex-AG DS-Alex-AG approved these changes

@danimtb danimtb danimtb left review comments

@jcar87 jcar87 Awaiting requested review from jcar87

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@valgur @conan-center-bot @AbrilRBS @jjcasmar @uilianries @danimtb @DS-Alex-AG