Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: remove old versions #21558

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Dec 3, 2023

Specify library name and version: libcurl/all

All versions up-to (and including) 8.5.0 have some vulnerabilities: https://repology.org/project/curl/cves


Copy link
Contributor

github-actions bot commented Dec 3, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/libcurl//'.

👋 @Hopobcn you might be interested. 😉

@mayeut
Copy link
Contributor Author

mayeut commented Dec 3, 2023

removed versions still used by other recipes:

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Hooks produced the following warnings for commit 14c1bfa
libcurl/8.4.0@#f242bbd1c18d2d8fea9660d832b2e14a
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Hooks produced the following warnings for commit 1a144a3
libcurl/8.4.0@#231b6b729a8aa13c730b66af2aeb8b5d
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some packages are still using libcurl versions listed to be removed:

find recipes -name conanfile.py -exec grep libcurl {} + 
...
recipes/cern-root/all/conanfile.py:        self.requires("libcurl/7.78.0")
recipes/kcov/all/conanfile.py:                "libcurl/7.83.1",
recipes/teemo/all/conanfile.py:        self.requires("libcurl/7.86.0")

Please, check which package are affected and do not remove those versions. Indeed libcurl allows ranged version, but not all recipes are update yet.

@valgur
Copy link
Contributor

valgur commented Dec 7, 2023

@uilianries just to be sure, did you see #21558 (comment)?

@mayeut
Copy link
Contributor Author

mayeut commented Dec 7, 2023

@uilianries,

recipes/teemo/all/conanfile.py: self.requires("libcurl/7.86.0")

You just closed the PR #21611 that gets version range in teemo, which would allow to remove 7.86.0 (once libvault gets updated as well).

@AbrilRBS
Copy link
Member

@mayeut fixed now, thanks for the heads-up

@uilianries
Copy link
Member

Let's update other versions first, because it will generate a new recipe revision.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Hooks produced the following warnings for commit 24e701a
libcurl/8.5.0@#4cc50d3aceed2f49c87c3e6bc4332014
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
libcurl/8.4.0@#c8222411c4eeffdd2261c2af6cb07131
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
libcurl/8.6.0@#c789295471982c3e2166e1a705cb1e95
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

@ghost ghost mentioned this pull request Mar 20, 2024
3 tasks
@ghost ghost mentioned this pull request Apr 5, 2024
3 tasks
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 24e701a
libcurl/8.5.0@#d5d606be375701da80b805cc099ed6ed
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
libcurl/8.4.0@#7903f7d25aac3baf708c2b205fb3c763
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
libcurl/8.6.0@#12828b806a417a5a75949264382ea5b2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurl.4.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request May 22, 2024
3 tasks
@jcar87 jcar87 self-assigned this Jun 11, 2024
@uilianries uilianries self-requested a review June 11, 2024 13:06
uilianries
uilianries previously approved these changes Jun 11, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The ConanCenterIndex supports version ranges for libcurl, so all ported recipes that are working with Conan 2.x will be safe with this change. Only recipes that are not ported to Conan 2.x (yet) will consume those removed versions. However, there are PRs porting those recipes.

AbrilRBS
AbrilRBS previously approved these changes Jun 11, 2024
@AbrilRBS AbrilRBS assigned jcar87 and unassigned jcar87 Jun 11, 2024
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (31238a5c941c2a467d5cf4c8cb782d5c9729dc09):

  • libcurl/8.6.0:
    All packages built successfully! (All logs)

  • libcurl/8.5.0:
    All packages built successfully! (All logs)

  • libcurl/8.4.0:
    All packages built successfully! (All logs)

  • libcurl/8.8.0:
    All packages built successfully! (All logs)

  • libcurl/8.1.2:
    All packages built successfully! (All logs)

  • libcurl/8.0.1:
    All packages built successfully! (All logs)

  • libcurl/8.2.1:
    All packages built successfully! (All logs)

  • libcurl/7.88.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (31238a5c941c2a467d5cf4c8cb782d5c9729dc09):

  • libcurl/8.6.0:
    All packages built successfully! (All logs)

  • libcurl/8.8.0:
    All packages built successfully! (All logs)

  • libcurl/8.5.0:
    All packages built successfully! (All logs)

  • libcurl/8.2.1:
    All packages built successfully! (All logs)

  • libcurl/8.1.2:
    All packages built successfully! (All logs)

  • libcurl/8.4.0:
    All packages built successfully! (All logs)

  • libcurl/8.0.1:
    All packages built successfully! (All logs)

  • libcurl/7.88.1:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit b751798 into conan-io:master Jun 12, 2024
48 checks passed
@mayeut mayeut deleted the libcurl-remove-old branch June 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants