-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcurl: remove old versions #21558
libcurl: remove old versions #21558
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/libcurl//'. 👋 @Hopobcn you might be interested. 😉 |
removed versions still used by other recipes:
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 14c1bfalibcurl/8.4.0@#f242bbd1c18d2d8fea9660d832b2e14a
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1a144a3libcurl/8.4.0@#231b6b729a8aa13c730b66af2aeb8b5d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some packages are still using libcurl versions listed to be removed:
find recipes -name conanfile.py -exec grep libcurl {} +
...
recipes/cern-root/all/conanfile.py: self.requires("libcurl/7.78.0")
recipes/kcov/all/conanfile.py: "libcurl/7.83.1",
recipes/teemo/all/conanfile.py: self.requires("libcurl/7.86.0")
Please, check which package are affected and do not remove those versions. Indeed libcurl allows ranged version, but not all recipes are update yet.
@uilianries just to be sure, did you see #21558 (comment)? |
You just closed the PR #21611 that gets version range in teemo, which would allow to remove 7.86.0 (once libvault gets updated as well). |
@mayeut fixed now, thanks for the heads-up |
Let's update other versions first, because it will generate a new recipe revision. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 24e701alibcurl/8.5.0@#4cc50d3aceed2f49c87c3e6bc4332014
libcurl/8.4.0@#c8222411c4eeffdd2261c2af6cb07131
libcurl/8.6.0@#c789295471982c3e2166e1a705cb1e95
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 24e701alibcurl/8.5.0@#d5d606be375701da80b805cc099ed6ed
libcurl/8.4.0@#7903f7d25aac3baf708c2b205fb3c763
libcurl/8.6.0@#12828b806a417a5a75949264382ea5b2
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The ConanCenterIndex supports version ranges for libcurl, so all ported recipes that are working with Conan 2.x will be safe with this change. Only recipes that are not ported to Conan 2.x (yet) will consume those removed versions. However, there are PRs porting those recipes.
f3a99ad
to
e60783b
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: libcurl/all
All versions up-to (and including) 8.5.0 have some vulnerabilities: https://repology.org/project/curl/cves