-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsystemd: Include libudev #20290
libsystemd: Include libudev #20290
Conversation
da2fe83
to
867bf7b
Compare
867bf7b
to
58e8085
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 58e8085libsystemd/253.6@#0e9ee2ad078aeeb072105d299b038ec3
|
This comment has been minimized.
This comment has been minimized.
Not as far as I know, no. I've added this recipe to our next team review meeting, will let you |
This comment has been minimized.
This comment has been minimized.
Looks like it is most likely a compiler bug causing the compilation error and not an actual issue with the project. I wonder if it's the version of GCC 9 in CI causing problems. |
Yep, works with GCC 9.4. I'll add a workaround similar to Qt 6. |
7ec4535
to
c787338
Compare
c787338
to
2b507c7
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
498fa3a
to
3fd39cc
Compare
This comment has been minimized.
This comment has been minimized.
9e959af
to
fb738ad
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This PR is necessary for #20358, which requires a newer version of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 23 (
Conan v2 pipeline ✔️
All green in build 23 (
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: libsystemd/*
Include the udev library as a component of the libsystemd package.
Update Meson version.
Add
provides = "libudev"
to allow other providers of thelibudev
library, i.e.eudev
.It seems like the
provides
should be related to thelibudev
component instead of the entire package.Is this possible?
I wasn't sure whether to add a separate package for libudev, i.e. something under
libudev/all
, or to include it as part of the libsystemd package.In light of the fact that a separate package requires more resources to maintain, I opted for including it in the libsystemd package.
This will require only updating one package in CCI instead of two, at the cost of flexibility for managing libudev and libsystemd in distinct ways, i.e. trying to build one shared and the other static.