Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsystemd/253.*: Fix cross-compilation #20557

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: libsystemd/253.*

Bump versions of pkgconf and Meson.
Add a patch to ensure that necessary compiler flags are passed through when the build system is invoking the compiler to generate files.
Without the proper compiler flags when cross-compiling, the system include directories and such are used which causes problems.
The patch has been applied upstream in systemd/systemd#29538.


@ghost
Copy link

ghost commented Oct 13, 2023

I detected other pull requests that are modifying libsystemd/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (676c9eb4e947fe4713ef35bd420646e4c163e50d):

  • libsystemd/253.6:
    All packages built successfully! (All logs)

  • libsystemd/253.3:
    All packages built successfully! (All logs)

  • libsystemd/253.10:
    All packages built successfully! (All logs)

  • libsystemd/252.9:
    All packages built successfully! (All logs)

  • libsystemd/246.16:
    All packages built successfully! (All logs)

  • libsystemd/249.16:
    All packages built successfully! (All logs)

  • libsystemd/251.15:
    All packages built successfully! (All logs)

  • libsystemd/247.13:
    All packages built successfully! (All logs)

  • libsystemd/248.12:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (676c9eb4e947fe4713ef35bd420646e4c163e50d):

  • libsystemd/253.10:
    All packages built successfully! (All logs)

  • libsystemd/253.3:
    All packages built successfully! (All logs)

  • libsystemd/252.9:
    All packages built successfully! (All logs)

  • libsystemd/251.15:
    All packages built successfully! (All logs)

  • libsystemd/253.6:
    All packages built successfully! (All logs)

  • libsystemd/249.16:
    All packages built successfully! (All logs)

  • libsystemd/247.13:
    All packages built successfully! (All logs)

  • libsystemd/246.16:
    All packages built successfully! (All logs)

  • libsystemd/248.12:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Oct 14, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see that you yourself fixed it upstream 🫶

@jwillikers
Copy link
Contributor Author

It's great to see that you yourself fixed it upstream 🫶

Thanks! 😊 It would feel way cooler if I wasn't simply unreverting a single-line change from 5 years ago that ended up fixing the problem after updates to Meson 4 years ago, but that seems to be the way of Open Source at times. I've yet to grasp why no one had fixed this in the past 4 years, though. 🤔

@ghost ghost mentioned this pull request Oct 16, 2023
3 tasks
@conan-center-bot conan-center-bot merged commit 4db3243 into conan-io:master Oct 18, 2023
54 checks passed
@jwillikers jwillikers deleted the libsystemd-patch-cross branch October 18, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants