-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsystemd/253.*: Fix cross-compilation #20557
libsystemd/253.*: Fix cross-compilation #20557
Conversation
I detected other pull requests that are modifying libsystemd/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see that you yourself fixed it upstream 🫶
Thanks! 😊 It would feel way cooler if I wasn't simply unreverting a single-line change from 5 years ago that ended up fixing the problem after updates to Meson 4 years ago, but that seems to be the way of Open Source at times. I've yet to grasp why no one had fixed this in the past 4 years, though. 🤔 |
Specify library name and version: libsystemd/253.*
Bump versions of pkgconf and Meson.
Add a patch to ensure that necessary compiler flags are passed through when the build system is invoking the compiler to generate files.
Without the proper compiler flags when cross-compiling, the system include directories and such are used which causes problems.
The patch has been applied upstream in systemd/systemd#29538.