Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdal: migrate to Conan v2, bump to v2.6.0, unvendor all available packages #21296

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 21, 2023

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@zap150
Copy link

zap150 commented Jan 11, 2024

Hi @valgur, I know it's difficult to give some ETA, but can you guess how difficult it will be to finish this migration? We are in fact waiting for the byproduct of this migration, i.e. the 2.6 version of the package. Thanks for your effort!

@valgur
Copy link
Contributor Author

valgur commented Jan 11, 2024

@zap150 The recipe itself should be usable, but it's blocked by two PRs (GDAL and Arbiter). GDAL should be merged any day (or week) now, no idea about Arbiter.

If it's an option for you, you can upload the recipe to you own package repository or include it in your source repositary and use this hack: https://github.com/valgur/cupoch/blob/67d4276956d546b46e8b4e27e5ef095229a30e64/conanfile.py#L99-L105

@marxin
Copy link

marxin commented Jan 11, 2024

Thank you! About Arbiter: is it an essential package dependency or just an optional one?

@ghost ghost mentioned this pull request Feb 10, 2024
3 tasks
@trns1997
Copy link
Contributor

Thank you! About Arbiter: is it an essential package dependency or just an optional one?

@marxin arbiter seems to be an essential package from what i can see in PDALs CMakeList

@trns1997
Copy link
Contributor

@valgur now that gdal is merged. Could you look into my suggestions that way we can get pdal merged as well soon :)

@conan-center-bot

This comment has been minimized.

@trns1997
Copy link
Contributor

@valgur I vaguely followed the conversation regarding the unvendoring of packages for PDAL, seems like it is not going to happen. So i was wondering what happens now? Do you plan to package PDAL using their vendored packages? or is the conversation still up for debate?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented May 30, 2024

#24165

@valgur valgur closed this May 30, 2024
@valgur valgur reopened this Jul 1, 2024
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Jul 1, 2024
@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 15, 2024

Should merge #23233 first to fix the GDAL recipe bugs.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Aug 2, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 2 (3b607c181fd73d2eff20f06bb967e425cc624aa0):

  • pdal/2.7.2:
    Error running command conan info pdal/2.7.2@#6567111366a7408c1a3650c2c333d8e3 --json {jsonName} --dry-build -pr {profileName}:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    
    ...
    ERROR: Failed requirement 'gdal/3.9.1' from 'pdal/2.7.2'
    ERROR: Unable to find 'gdal/3.9.1' in remotes
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 2 (3b607c181fd73d2eff20f06bb967e425cc624aa0):

  • pdal/2.7.2:
    Error running command conan graph info --requires pdal/2.7.2@#6567111366a7408c1a3650c2c333d8e3 --build pdal/2.7.2@#6567111366a7408c1a3650c2c333d8e3 -f json -pr:h /home/conan/workspace/prod-v2/bsr/69454/ffbac/profile_linux_11_libstdcpp11_17_gcc_release_64.-shared-False.txt -pr:b /home/conan/workspace/prod-v2/bsr/69454/ffbac/profile_linux_11_libstdcpp11_17_gcc_release_64..txt:
    ======== Computing dependency graph ========
    eigen/3.4.0: Not found in local cache, looking in remotes...
    eigen/3.4.0: Checking remote: conan-center
    eigen/3.4.0: Downloaded recipe revision 2e192482a8acff96fe34766adca2b24c
    gdal/3.9.1: Not found in local cache, looking in remotes...
    gdal/3.9.1: Checking remote: conan-center
    gdal/3.9.1: Checking remote: c3i_PR-v2-21296
    Graph root
        cli
    Requirements
        eigen/3.4.0#2e192482a8acff96fe34766adca2b24c - Downloaded (conan-center)
        pdal/2.7.2#6567111366a7408c1a3650c2c333d8e3 - Cache
    ERROR: Package 'gdal/3.9.1' not resolved: Unable to find 'gdal/3.9.1' in remotes.
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@valgur valgur mentioned this pull request Aug 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants