-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus: fix build of 1.15.8 with Visual Studio 2022 #22156
dbus: fix build of 1.15.8 with Visual Studio 2022 #22156
Conversation
Instead of using has_header use check_header to confirm the header works. This is necessary to get the meson build to work with Visual Studio 2022. It has <stdatomic.h> but it does not actually work when compiling a C program. Fixes conan-io#19421
🤖 Beep Boop! This pull request is making changes to 'recipes/dbus//'. 👋 @jwillikers you might be interested. 😉 |
I detected other pull requests that are modifying dbus/1.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on a fix upstream.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's wait for upstream decision on merging their PR before merging this one, please ping me when the PR is updated, thanks! :)
@RubenRBS, the upstream PR has been merged. Will you approve this PR now? Once approved do I need to update the branch? The CI comment says "This branch is out-of-date with the base branch" next to a warning icon, but it is not clear to me if this is just a warning or an issue that needs to be addressed before the PR can be merged automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
but it is not clear to me if this is just a warning or an issue that needs to be addressed before the PR can be merged automatically.
It's just GitHub's way to notify contributors that changes arrived in the main branch not present in this PR, but nothing to worry about unless it also shows that there are conflcits!
Approved, thanks a lot! :)
Instead of using has_header use check_header to confirm the header works. This is necessary to get the meson build to work with Visual Studio 2022. It has <stdatomic.h> but it does not actually work when compiling a C program.
Fixes #19421
See also associated upstream issue and merge request:
Specify library name and version: dbus/1.15.8