Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conanfile.py #22094

Closed
wants to merge 1 commit into from
Closed

Conversation

anonymousdouble
Copy link

refactor with chain constant value assignment to make code more Pythonic, concise and efficient.

Specify library name and version: lib/1.0


refactor with chain constant value assignment to make code more Pythonic, concise and efficient.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Jan 1, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/dbus//'.

👋 @jwillikers you might be interested. 😉

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@valgur
Copy link
Contributor

valgur commented Mar 24, 2024

Thank you for the contribution, but I find that more difficult to read than before. Voting to close this.

It's usually better to have assignment statements vertically aligned to easily distinguish what each statement is doing differently.

@jcar87
Copy link
Contributor

jcar87 commented Jun 6, 2024

Hi @anonymousdouble - thank you for your pull request.

Closing this, as this does not offer benefits to the recipe's end users, and that section of the code is unlikely to survive the year anyway.

@jcar87 jcar87 closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants