Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus: Use relative folders for directories #23437

Merged
merged 1 commit into from
Apr 12, 2024
Merged

dbus: Use relative folders for directories #23437

merged 1 commit into from
Apr 12, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Apr 9, 2024 •
edited
Loading

Use relative folders due to this change: conan-io/conan#15706. Remove the useless attempt to modify the separators used for the prefix path. The separators are still inconsistent for the prefix and exec_prefix on Windows. They use both backslashes and forward slashes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/dbus//'.

👋 @jwillikers you might be interested. 😉

@ghost
Copy link

ghost commented Apr 9, 2024

I detected other pull requests that are modifying dbus/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Apr 9, 2024
Closed
Closed
@jwillikers jwillikers force-pushed the dbus-relative-datadir branch 2 times, most recently from a77f490 to 785a2ed Compare April 9, 2024 12:53
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers
dbus: Use relative folders for directories
73c07f3 
Use relative folders due to this change: conan-io/conan#15706
Remove the useless attempt to modify the separators used for the prefix path.
The separators are still inconsistent for the prefix and exec_prefix on Windows.
They use both backslashes and forward slashes.
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (73c07f38edd86aff5b0b37e584764278b4f1de71):

  • dbus/1.15.8:
    All packages built successfully! (All logs)

  • dbus/1.15.6:
    All packages built successfully! (All logs)

  • dbus/1.15.2:
    All packages built successfully! (All logs)

  • dbus/1.15.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (73c07f38edd86aff5b0b37e584764278b4f1de71):

  • dbus/1.15.8:
    All packages built successfully! (All logs)

  • dbus/1.15.6:
    All packages built successfully! (All logs)

  • dbus/1.15.2:
    All packages built successfully! (All logs)

  • dbus/1.15.0:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Apr 9, 2024
Open
AbrilRBS
AbrilRBS approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbrilRBS AbrilRBS self-assigned this Apr 12, 2024
@conan-center-bot conan-center-bot merged commit 4522d7a into conan-io:master Apr 12, 2024
28 checks passed
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
@jwillikers
(conan-io#23437) dbus: Use relative folders for directories
20dc40c 
Use relative folders due to this change: conan-io/conan#15706
Remove the useless attempt to modify the separators used for the prefix path.
The separators are still inconsistent for the prefix and exec_prefix on Windows.
They use both backslashes and forward slashes.
@jwillikers jwillikers deleted the dbus-relative-datadir branch April 12, 2024 11:53
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
@jwillikers @ericLemanissier
(conan-io#23437) dbus: Use relative folders for directories
7392f46 
Use relative folders due to this change: conan-io/conan#15706
Remove the useless attempt to modify the separators used for the prefix path.
The separators are still inconsistent for the prefix and exec_prefix on Windows.
They use both backslashes and forward slashes.
@ericLemanissier ericLemanissier mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwillikers @conan-center-bot @franramirez688 @AbrilRBS