-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt refactor option handling and error reporting #24876
qt refactor option handling and error reporting #24876
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug needs to be changed for Conan 1, otherwise this looks great!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
956fb1b
to
673c764
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 673c764qt/5.15.14@#8e99c640555798c4c2b5dedfcff7c394
qt/6.6.3@#a2c29e7b43dfbd6aa42d47a008d4b891
qt/6.7.1@#f9894f8217c84802f23a1ad698078e71
qt/6.5.3@#cfff08010dfc06ce2fce147971d6976f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 ( |
Recipes: qt5 and qt6
Summary
essential_modules
is False by default in all casesconan graph explain
(see Cannot install qt 6.7.0 prebuilt binary on Windows conan#16215)-vv
)"ConanException: Incorrect attempt to modify option 'qtmultimedia' from 'False' to 'True'"
ERROR: qt/5.15.14: Invalid configuration: Modules ['qtgraphicaleffects'] are explicitly disabled, but are required by ['qtquickcontrols2'], enabled by other options
Close conan-io/conan#16215
Close #23567
Details
-o
, inside a profile, or propagated from another recipe that requires thisDefault behaviour when no options are passed
False
by defaultgui
andwidgets
are built by defaultWhen specific submodules are set set to
=True
=True
as well, even if they were not enabled explicitlyWhen any submodule is explicitly set to
=False
True
, this will now display a more informative errorNotes convenience options, e.g
essential_modules=True
=True
, as if they had been explicitly requested individually - as per the logic aboveessential_modules=True
, but some modules are explicitly set toFalse
:Warning
There are some issues with the granularity of
essential_modules=True
and would discourage its useNamely: the recipe expresses modules at the level of the Qt repositories, however, as per Qt's website) these are expressed directly as modules. We have observed some issues:
qtdoc
is marked as "essential" by the recipe - but this generates the Qt documentation, which is unlikely to be essential to the recipe consumersqttools
- some tools are arguably not essential, but they're all lumped togetherqtwebengine
is enabled