-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt (5 & 6): provide versionless Qt targets in CMakeDeps #25198
base: master
Are you sure you want to change the base?
qt (5 & 6): provide versionless Qt targets in CMakeDeps #25198
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
Hooks produced the following warnings for commit 2eedf9bqt/5.15.14@#81b9f67fecfcccb8ba73b675a15253cb
qt/6.7.1@#32aed0686e2634c36bdd9f95d5624ed1
qt/6.6.3@#28423ee76256da8538d5ae897b651164
qt/6.5.3@#570dac14438db85ee8299d72ab50a267
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By the way, it would be nice to fix conan v2 migration linter. Since #24876, this linter reports a false positive in qt recipe, so PR are globally reported as failing while it's not the case, so reviewers may not review these PRs. |
Hi @SpaceIm
We are working on a conan linter which will be introduced in the nearby future. For now, lets ignore this |
Summary
Changes to recipe: qt/all
Motivation
Official config files of Qt provide versionless targets (like
Qt::Core
, which is an alias of eitherQt5::Core
orQt6::Core
) as described in https://doc-snapshots.qt.io/qt6-dev/cmake-qt5-and-qt6-compatibility.html. This PR aims to expose these target names in CMakeDeps.Details
closes #6459