Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for the LLVM core libraries #3375
Add recipe for the LLVM core libraries #3375
Changes from 4 commits
6c6d87b
8e4e4d0
daa072b
b735998
edf9abc
aebb740
6fdd6a6
00c52c8
41562aa
d876521
9cb7274
d8286db
b9347da
881ce17
d0c2201
329d69e
d876b34
c9a784c
cf7b3c0
8ce9dec
01e6a26
33c36f2
bb7baec
59d8248
1ef186a
d30f900
7c9f6ef
304a14e
563e571
e79842e
c0ab4e7
194cf21
e021639
d99091d
c4ae50c
e5b2dee
f6a023b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a remark for all reviewers (and my future self), this is actually the correct SPDX annotation 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this @intelligide? Instead of parsing
LLVMExports.cmake
, I use cmake to output the dependency graph as a graphviz's dot file which is way easier to parse.It still uses a regular expression, but it is a simple one. The alternative would be using external tools like graphviz plus networkx that will do the parsing for you, but then you'll introduce a dependency on those tools that may not be installed along conan. I think this solution is easy and maintainable enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better (not perfect yet but better than nothing).