Add pybind11/2.4.3 recipe

[madebr]

Specify library name and version: pybind11/2.4.3

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

Fixes #424

[conan-center-bot]

Some configurations of 'pybind11/2.4.3' have failed:

• Linux x86_64, Release, gcc 5, libstdc++
  • Hooks errors detected:
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[madebr]

@uilianries
I've added "lib/cmake/pybind11" to self.cpp_info.builddirs but it is still failing.
The files in that directory are:

• pybind11Tools.cmake: contains function to create a python module
• FindPythonLibsNew.cmake: contains helper function to find the python executable and libraries
  It detects and sets more variables then FindPythonInterp.cmake and FindPythonLibs.cmake from cmake
  It is required by pybind11Tools.cmake

What do you suggest?

[danimtb]

@madebr please check the changes done here https://github.com/conan-community/conan-pybind11/compare/release/2.3.0...danimtb:release/2.3.0_build_modules?expand=1 as a proof of concept for build modules

[madebr]

@danimtb
Thanks for the link.
The issue with KB-H016 is that it does not allow Find*.cmake files which it needs.

[conan-center-bot]

Some configurations of 'pybind11/2.4.3' have failed:

• Linux x86_64, Release, gcc 5, libstdc++
  • Hooks errors detected:
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[danimtb]

@madebr yes, you can use them if those are correctly mapped in the self.cpp_info.builddirs. Please update the PR with those changes

[madebr]

@danimtb The only other recipe using self.cpp_info.builddirs is catch2.
In its build directory, there are: Catch.cmake, CatchAddTests.cmake and ParseAndAddCatchTests.cmake. No FindXXX.cmake file.

So I still do not know how to whitelist FindPythonLibsNex.cmake.

[danimtb]

ok, I will give it a go myself. Sorry for that

[uilianries]

The PR conan-io/hooks#145 puts pybind11 in the allow list for KB-H016

[uilianries]

LGTM

[danimtb]

@uilianries I think instead of allowing that via whitelist, we could check if cpp_info.build_modules adds those files and allow them. But maybe this is difficult to check in the hooks

[uilianries]

@danimtb we can check if r"Find{self.name}" is there and reject, otherwise, we can allow.

[conan-center-bot]

Some configurations of 'pybind11/2.4.3' failed in build 3 (830f0f92b69f7fd560c0e27c9be9dd7880a41aee):

• Linux x86_64, Release, gcc 5, libstdc++
  • Hooks errors detected:
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[danimtb]

@uilianries not sure about that as that might be tied to the name set in self.cpp_info.names["cmake_find_package"] not self.name. Maybe checking in lowercase mode?

[uilianries]

@danimtb Lowercase sounds better!

[uilianries]

@danimtb Thinking again, it will be better using self.cpp_info.names["cmake_find_package"] by default, because in some cases, the target name is not the same than the package name.

[danimtb]

yes, names might be different although most times us just a casing change. Don't know if that is possible to detect... But I think allowing files declared in build_modules is fine. We can check it in the PR review

[kylemacfarlan]

@danimtb @uilianries Is there anything blocking this getting merged? I'd love to have pybind11 in conan center.

[conan-center-bot]

Some configurations of 'pybind11/2.4.3' failed in build 5 (830f0f92b69f7fd560c0e27c9be9dd7880a41aee):

• Linux x86_64, Release, gcc 5, libstdc++
  • Hooks errors detected:
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
    • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[conan-center-bot]

All green in build 6 (830f0f92b69f7fd560c0e27c9be9dd7880a41aee)! 😊

• pybind11/2.4.3: Generated 1 packages. All logs here

[Croydon]

Please archive https://github.com/conan-community/conan-pybind11 @SSE4 @danimtb or someone else, thanks 😄

[Croydon]

Also these should probably be moved or closed https://github.com/conan-community/community/issues?q=is%3Aissue+is%3Aopen+pybind11

[danimtb]

Done! Thanks for the reminder @Croydon