Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable usage of new FindPython modules #4641

Conversation

planetmarshall
Copy link
Contributor

@planetmarshall planetmarshall commented Feb 22, 2021

Specify library name and version: pybind11/2.6.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

This minor change enables the use of the new FindPython modes in CMake as per the pybind11 documentation.

The FindPythonLibsNew.cmake file is included by pybind11Install indirectly depending on whether the new mode is used.

@ghost
Copy link

ghost commented Feb 22, 2021

I detected other pull requests that are modifying pybind11/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (e9547247b568236463d7b698d27013e63fb4f995):

  • pybind11/2.4.3@:
    All packages built successfully! (All logs)

  • pybind11/2.5.0@:
    All packages built successfully! (All logs)

  • pybind11/2.6.0@:
    All packages built successfully! (All logs)

  • pybind11/2.6.1@:
    All packages built successfully! (All logs)

  • pybind11/2.6.2@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries February 23, 2021 09:51
@prince-chrismc
Copy link
Contributor

These changes are listed for very recent versions of CMake which Conan does not support, is there a particular issue that you are trying to solve that requires this change?

@planetmarshall
Copy link
Contributor Author

These changes are listed for very recent versions of CMake which Conan does not support, is there a particular issue that you are trying to solve that requires this change?

We were already using the new FindPython support in an internal project, so it made sense to only use one method of finding the Python libraries. I also found it to be more reliable in the various different Python environments to be found on CI systems and local development machines.

FindPythonInterp and FindPythonLibs are deprecated in CMake as of 3.12

@uilianries
Copy link
Member

uilianries commented Mar 5, 2021

FindPythonLibsNew.cmake is there because one reason: #464 (comment)

I would suggest adding a new option (which doesn't affect the package ID), including or FindPythonLibsNew into cpp_info, but keep as True by default.

Your propose is legit, but not all users can run new Cmake versions.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (e9547247b568236463d7b698d27013e63fb4f995):

  • pybind11/2.4.3@:
    All packages built successfully! (All logs)

  • pybind11/2.5.0@:
    All packages built successfully! (All logs)

  • pybind11/2.6.0@:
    All packages built successfully! (All logs)

  • pybind11/2.6.1@:
    All packages built successfully! (All logs)

  • pybind11/2.6.2@:
    All packages built successfully! (All logs)

@stale
Copy link

stale bot commented Apr 7, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2021
@danimtb
Copy link
Member

danimtb commented Apr 20, 2021

I believe this has been adressed in #4445

@stale stale bot removed the stale label Apr 20, 2021
@SSE4 SSE4 closed this Apr 20, 2021
@planetmarshall planetmarshall deleted the pybind11-enable-new-find-python branch August 7, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants