-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable usage of new FindPython modules #4641
enable usage of new FindPython modules #4641
Conversation
I detected other pull requests that are modifying pybind11/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
All green in build 1 (
|
These changes are listed for very recent versions of CMake which Conan does not support, is there a particular issue that you are trying to solve that requires this change? |
We were already using the new FindPython support in an internal project, so it made sense to only use one method of finding the Python libraries. I also found it to be more reliable in the various different Python environments to be found on CI systems and local development machines.
|
I would suggest adding a new option (which doesn't affect the package ID), including or Your propose is legit, but not all users can run new Cmake versions. |
All green in build 2 (
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I believe this has been adressed in #4445 |
Specify library name and version: pybind11/2.6.2
conan-center hook activated.
This minor change enables the use of the new
FindPython
modes in CMake as per the pybind11 documentation.The
FindPythonLibsNew.cmake
file is included bypybind11Install
indirectly depending on whether the new mode is used.