Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider _global_defines in XcodeToolchain _check_if_extra_flags #16429

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jun 7, 2024

Changelog: Bugfix: Fix XcodeToolchain when only defines are set.
Docs: Omit

Closes: #16422

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

@czoido czoido force-pushed the xcodetoolchain-defines-global branch from 6538c08 to af8802f Compare June 10, 2024 06:13
@memsharded memsharded merged commit ad97c32 into conan-io:develop2 Jun 10, 2024
2 checks passed
@jacobfriedman
Copy link

signed post-facto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] XcodeToolchain's conan_global_flags.xcconfig not flagged to save if _global_defines is populated
4 participants