Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added self._global_defines check under def _check_if_extra_flags(self): #1

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from

Conversation

jacobfriedman
Copy link
Owner

Changelog: (Bugfix):

Docs state that the global xcode config will be generated with modification of the above, including exelinkflags and defines, but the _check_if_extra_flags(self) only checks for cflags/cxxflags/ldflags/exelinkflags.

Docs: https://docs.conan.io/2/reference/tools/apple/xcodetoolchain.html#xcodetoolchain-conf

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • [x ] I've read the Contributing guide.
  • [ x] I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Docs state that the global xcode config will be generated with modification of the above, including exelinkflags and defines, but the _check_if_extra_flags(self) only checks for cflags/cxxflags/ldflags/exelinkflags.

https://docs.conan.io/2/reference/tools/apple/xcodetoolchain.html#xcodetoolchain-conf
@czoido
Copy link

czoido commented Jun 7, 2024

Hi @jacobfriedman,
Thanks for the contribution, it looks good, I'm adding a test and I think we can merge when the ci passes.

@czoido
Copy link

czoido commented Jun 7, 2024

@jacobfriedman I picked your commit, could you please sign the CLA here: conan-io#16429 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants