Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth_plugin with tests #16942

Merged
merged 19 commits into from
Sep 23, 2024
Merged

Add auth_plugin with tests #16942

merged 19 commits into from
Sep 23, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Sep 5, 2024 •
edited by czoido
Loading

Changelog: Feature: New auth_remote.py plugin for custom user authentication to Conan remotes.
Changelog: Feature: New auth_source.py plugin for custom user authentication for generic downloads of sources.
Changelog: Bugfix: Allow remote_login accept patterns.
Docs: conan-io/docs#3846

Close #4266
Close #4196

If we are going have two diferent plugins one for remote auth and another one for source credentials we might want to change this name, I have though remote_auth_plugin and source_auth_plugin

@ErniGH ErniGH requested a review from memsharded September 5, 2024 15:14
AbrilRBS
AbrilRBS reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/suggestions to discuss

conans/client/rest/remote_credentials.py Outdated Show resolved Hide resolved
conans/client/rest/remote_credentials.py Outdated Show resolved Hide resolved
test/integration/configuration/test_auth_plugin.py Outdated Show resolved Hide resolved
memsharded
memsharded reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

conans/client/migrations.py Outdated Show resolved Hide resolved
conans/client/rest/remote_credentials.py Outdated Show resolved Hide resolved
conans/client/rest/remote_credentials.py Outdated Show resolved Hide resolved
AbrilRBS
AbrilRBS reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test, otherwise looks good!

conans/client/rest/remote_credentials.py Show resolved Hide resolved
@AbrilRBS AbrilRBS added this to the 2.8.0 milestone Sep 11, 2024
@AbrilRBS AbrilRBS assigned AbrilRBS and unassigned AbrilRBS Sep 11, 2024
@memsharded memsharded self-assigned this Sep 11, 2024
@ErniGH ErniGH marked this pull request as ready for review September 13, 2024 12:37
memsharded
memsharded reviewed Sep 13, 2024
View reviewed changes
conans/client/rest/conan_requester.py Outdated Show resolved Hide resolved
conans/client/rest/conan_requester.py Outdated Show resolved Hide resolved
conans/client/rest/remote_credentials.py Outdated Show resolved Hide resolved
@ErniGH ErniGH mentioned this pull request Sep 18, 2024
Merged
memsharded
memsharded approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think looks good to move forward, good job

franramirez688
franramirez688 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@memsharded memsharded requested a review from AbrilRBS September 22, 2024 17:41
ErniGH and others added 2 commits September 22, 2024 23:16
@ErniGH @AbrilRBS
Update test/integration/configuration/test_auth_remote_plugin.py
126dbe9 
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
@ErniGH
test fix
d03623d
AbrilRBS
AbrilRBS approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@memsharded memsharded merged commit d0eb5f2 into conan-io:develop2 Sep 23, 2024
2 checks passed
This was referenced Sep 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.8.0
4 participants
@ErniGH @franramirez688 @AbrilRBS @memsharded