Adding documentation for the new auth plugin #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Sep 18, 2024
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
|
I think it would be nice to add a link here from places where we talk about servers so that it's more easily discoverable by users. If not it will be difficult that users reach this content. |
memsharded
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Looking good. I think it would be great to add a subsection or something that explains the resolution order/priority:
- First the plugins
- If the plugins return nothing, then the credentials.json
- If the credentials.json returns nothing, then the env-vars
- Finally the user interactive prompt or fail if the "non_interactive" config is enabled
This might be a section in other place in the docs that talks about authorization process, but I cannot think at the moment where. If not evident, it can be done here at the moment.
memsharded
reviewed
Sep 25, 2024
memsharded
approved these changes
Sep 25, 2024
memsharded
requested changes
Sep 25, 2024
czoido
approved these changes
Sep 26, 2024
memsharded
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: conan-io/conan#16942