Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to show that you need to pass skip_binaries conf to build #16975

Closed

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Sep 11, 2024

Changelog: Omit
Docs: Omit

As part of the investigation for #16957, this only adds a test to document behaviopru that while consistent with respect to the whole codebase and context separation, can be a bit suprising for users

AbrilRBS and others added 2 commits September 11, 2024 12:40
context to avoid skipping tools

---------

Co-authored-by: PerseoGI <perseog@jfrog.com>
@AbrilRBS AbrilRBS added this to the 2.8.0 milestone Sep 11, 2024
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still a bit confused about why in the original issue the virtualbuildenv is not complete when saying skip_binaries=False. Why forcing to download the binaries creates a different environment?

@memsharded memsharded self-assigned this Sep 11, 2024
@memsharded
Copy link
Member

Superseded by #17033

@memsharded memsharded closed this Sep 23, 2024
@czoido czoido removed this from the 2.8.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants