Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix skip binaries #17033

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix skip binaries #17033

merged 1 commit into from
Sep 23, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Sep 22, 2024

Changelog: Bugfix: Do not skip dependencies of a package if it is not going to be skipped due to tools.graph:skip_binaries=False.
Docs: Omit

Close #16957

@AbrilRBS
Copy link
Member

AbrilRBS commented Sep 23, 2024

Very nice catch!

@memsharded memsharded marked this pull request as ready for review September 23, 2024 07:45
@czoido czoido merged commit b10a5f6 into conan-io:develop2 Sep 23, 2024
2 checks passed
@memsharded memsharded deleted the fix/skip_binaries branch September 23, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tools.graph:skip_binaries=False generates incomplete buildenv scripts
3 participants