[WIP TRACKING PR] Offline mode #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
===========================================
- Coverage 85.45% 74.54% -10.92%
===========================================
Files 78 92 +14
Lines 2503 3473 +970
Branches 609 757 +148
===========================================
+ Hits 2139 2589 +450
- Misses 358 877 +519
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
this also changes the answers stored in indexedDB to have an resource_url instead of an activity field
this also switches the url parameter name from report-source to sourceKey
…entUrl a question id mismatch is only seen when looking at the portal-report what really maters is the `activity` url parameter on the assignment in the portal, that is what the portal-report uses. but we'll want the resourceUrl here to match the activity parameter for when the student starts using the activity when working offline.
this also changes the name of the database to avoid migration issues
The issue is that the AP code using the storage facade, doesn't update its own answer objects. It is counting on the storage facade to call its answerWatcher callback and then it updates the answer object. So the dexie provider needs to implement the answerWatcher better. The implementation here does does this watching within the current tab. It isn't using dexie observable or something similar to watch for changes across tabs. Also this code isn't supporting the unsubscribing of the watchers. It doesn't look like the AP code is calling this unsubscribe, in the normal case, but it should be.
the manifest doesn't have a cacheList yet
It seems like the manifest authoring system doesn't pick up all assets. So I think this list is incomplete.
…nifest Add multi activity manifest
…-contentUrl update several parts of offline-mode
[#177348535] -- Add optional`force_offline_data=true` query parameter https://www.pivotaltracker.com/story/show/177348535
One more typing fix
Manifest update and more documentation
[#177348535] -- Add optional`force_offline_data=true` query parameter https://www.pivotaltracker.com/story/show/177348535
…te-answers hacky untyped fix for the duplicate answers problem
[#177348535] -- Add optional `__forceOfflineData` query parameter https://www.pivotaltracker.com/story/show/177348535
[#177348535] -- Add optional `__forceOfflineData` query parameter https://www.pivotaltracker.com/story/show/177348535
…offline_data-param Type out query parameter keys, add `force_offline_data` key.
…e-regression Fix merge regression _currentOfflineActivityId → _currentOfflineResourceURL
The 0 status code is returned for opaque responses. Since our fetch based cache filler use the no-cors option we get opaque responses for all external non-cors enabled servers.
…t-plugin-state Save plugin state when exporting student data to JSON
…cache Add 0 as valid cacheable response
This prevents the situation where the files start installing before the service worker is updated. Often when the install page is updated, the service worker needs to be updated too, so this insures the the two versions match before running the install.
…econnect-issues Check for existing FB connection before making a new one.
…tching-sw-version Only start installing if the service worker version matches
…-glossary-version Update glossary urls in offline manifest config to latest version
This has no manual changes. It hasn't been tested yet.
manually add an additional lato font that I saw was being requested during testing
PC content v6
Also moved some storage-facade related type declarations to the top of the file. [#177343947] Adding spec tests for storage facade https://www.pivotaltracker.com/story/show/177343947
[#177343947] Adding spec tests for storage facade https://www.pivotaltracker.com/story/show/177343947
…-storage-tests 177343947 add offline storage tests
clean up lint warnings
This makes it easier to test script changes. If --no-fetch-activities is used and --bump-version is not used, then the manifest and activities will be updated in place. The activities will not be fetched, but they might change if the script does modifications that haven't been done already.
…est-updating add support for in place manifest updating
Tests and doc updates
Pc content v7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the long running offline branch.
This Draft PR is to help us track how we are doing with code coverage and see if there are merge conflicts when new code shows up in master.