Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import of v2 documents with maps #1659

Merged
merged 3 commits into from
Dec 2, 2024

chore: add jest test for map importer

6d86b2d
Select commit
Loading
Failed to load commit list.
Merged

fix: import of v2 documents with maps #1659

chore: add jest test for map importer
6d86b2d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

85.74% (+0.04%) compared to 4e85e70

View this Pull Request on Codecov

85.74% (+0.04%) compared to 4e85e70

Details

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (4e85e70) to head (6d86b2d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/map/models/map-content-model.ts 75.00% 3 Missing ⚠️
v3/src/v2/codap-v2-types.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
+ Coverage   85.69%   85.74%   +0.04%     
==========================================
  Files         604      604              
  Lines       30740    30759      +19     
  Branches     7895     8430     +535     
==========================================
+ Hits        26344    26374      +30     
+ Misses       4241     4064     -177     
- Partials      155      321     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.