-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated sample rubric to v1.2 and added tag images and phrases [PT-188479846] #483
Conversation
portal-report Run #1890
Run Properties:
|
Project |
portal-report
|
Branch Review |
188479846-update-sample-rubric-to-use-tags
|
Run status |
Passed #1890
|
Run duration | 03m 54s |
Commit |
a88d1721f8: feat: Updated sample rubric to v1.2 and added tag images and phrases [PT-1884798...
|
Committer | Doug Martin |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
5
|
Skipped |
0
|
Passing |
187
|
View all changes introduced in this branch ↗︎ |
766cf89
to
1f9fcd4
Compare
…T-188479846] Also added debug:rubricSummaryTableOverride query parameter to override the tag summary table rubric option.
1f9fcd4
to
a88d172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just had one question.
@@ -66,6 +80,7 @@ const migrations = [ | |||
version: "1.2.0", | |||
migrations: [ | |||
createCriteriaGroups, | |||
fixUndefinedIconPhrase, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the version number will already be 1.2.0, it doesn't seem like this function will actually run when a rubric is fetched. Is that going to be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'll do it in the summary table display PR so I don't have to rebase and push the current follow on PT.
Also added debug:rubricSummaryTableOverride query parameter to override the tag summary table rubric option.