feat: Updated sample rubric to v1.2 and added tag images and phrases [PT-188479846] #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portal-report
|
||||||||||||||||||||||||||||
| Project |
portal-report
|
| Branch Review |
188479846-update-sample-rubric-to-use-tags
|
| Run status |
|
| Run duration | 03m 54s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
187
|
| View all changes introduced in this branch ↗︎ | |
dougmartin
force-pushed
the
188479846-update-sample-rubric-to-use-tags
branch
from
766cf89
to
1f9fcd4
Compare
…T-188479846] Also added debug:rubricSummaryTableOverride query parameter to override the tag summary table rubric option.
dougmartin
force-pushed
the
188479846-update-sample-rubric-to-use-tags
branch
from
1f9fcd4
to
a88d172
Compare
bgoldowsky
approved these changes
Oct 25, 2024
| @@ -66,6 +80,7 @@ const migrations = [ | |||
| version: "1.2.0", | |||
| migrations: [ | |||
| createCriteriaGroups, | |||
| fixUndefinedIconPhrase, | |||
There was a problem hiding this comment.
Since the version number will already be 1.2.0, it doesn't seem like this function will actually run when a rubric is fetched. Is that going to be a problem?
There was a problem hiding this comment.
Good point - I'll fix that.
There was a problem hiding this comment.
Actually I'll do it in the summary table display PR so I don't have to rebase and push the current follow on PT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added debug:rubricSummaryTableOverride query parameter to override the tag summary table rubric option.