Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add icons to summary table [PT-188404151] #484

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dougmartin
Copy link
Member

This was missing in the initial development.

Copy link

cypress bot commented Oct 25, 2024

portal-report    Run #1891

Run Properties:  status check passed Passed #1891  •  git commit d2728202d1: feat: Add icons to summary table [PT-188404151]
Project portal-report
Branch Review 188404151-add-icons-to-rubric-summary-table
Run status status check passed Passed #1891
Run duration 04m 02s
Commit git commit d2728202d1: feat: Add icons to summary table [PT-188404151]
Committer Doug Martin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 187
View all changes introduced in this branch ↗︎

Copy link

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dougmartin dougmartin force-pushed the 188479846-update-sample-rubric-to-use-tags branch from 766cf89 to 1f9fcd4 Compare October 25, 2024 15:19
@dougmartin dougmartin force-pushed the 188404151-add-icons-to-rubric-summary-table branch 2 times, most recently from 157d131 to 0de1fd4 Compare October 25, 2024 16:20
@dougmartin dougmartin force-pushed the 188479846-update-sample-rubric-to-use-tags branch from 1f9fcd4 to a88d172 Compare October 25, 2024 16:33
This was missing in the initial development.
@dougmartin dougmartin force-pushed the 188404151-add-icons-to-rubric-summary-table branch from 0de1fd4 to d272820 Compare October 25, 2024 16:42
Base automatically changed from 188479846-update-sample-rubric-to-use-tags to master October 25, 2024 17:34
@dougmartin dougmartin merged commit bc6c421 into master Oct 25, 2024
6 checks passed
@dougmartin dougmartin deleted the 188404151-add-icons-to-rubric-summary-table branch October 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants