-
-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Pin all the way to the patch level as they include the patch version in the SONAME. https://abi-laboratory.pro/index.php?view=timeline&l=boost
Rebuild now that `run_exports` is used.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cc @conda-forge/core (for awareness) |
how did we not have this before? Also, we should eventually remove the |
Just a note, a good portion of |
@kkraus14 - in that case, there is a mechanism to avoid run-exports in the deps that need/want to |
It's a great question, Matt. Was also surprised. In any event, this should fix it 🙂 Yeah there's |
Right. Downstreams can skip things. We could also further subdivide the boost package, making the header only parts a separate output and dep of boost-cpp. |
We could ship a repodata patch if we wanted to remove that now. I am agnostic on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a big discussion of not using run_exports
in boost-cpp. I can't find the discussion right now.
Until all the recipes in conda-forge which use headers only are fixed with ignore_run_exports
, -1 from me. If you can do the leg work to fix all the recipes before merging this, I'm okay with this.
25f8f9f
to
b223948
Compare
Ahh ok. I didn't know about that until now. If you can find the text of it, I'd love to read to catch up. In the meantime, maybe @jakirkham we should comment out the run export in the recipe and leave a comment on the underlying issues and steps needed to resolve them? This way newcomers don't have to backtrack and ultimately rely on the memories of ppl watching PRs to get it right. |
I'd rather just leave the PR open instead of merging with a comment. It didn't take us long to find the issue. Plus this makes it clear that this work still needs to be done. If there's relevant conversation, we can track it here as well. |
How about we solve this with a separate output rather than requiring recipes which only need header-only boost to add the right In contrast, if a recipe declares a host-dependence on (say) (yes, I'm thinking about eventually renaming PS. Having a header-only version would independently be useful e.g. to scipy (which vendors the headers), and arrow-cpp, see here, and AFAICT that would remove a bunch of packages from the boost-migration circuit, because IIUC the header-only dependencies wouldn't need to be pinned. |
Why not just add |
Do I understand correctly that you think an additional header-only output is worth considering? The naming discussion can come after ;) (I personally find boost-cpp & boost-hpp too close for comfort - plus the lib-prefix would be nice to have uniformly - but I agree "hpp" is a neat idea.) |
AnacondaRecipes/boost-feedstock have all of these. What we have to do is to sync this recipe with that. Nvm. there's no |
Yeah, from what I could tell, boost-cpp only has one output (and the boost feedstock is for the python bindings based on boost-cpp). AnacondaRecipes using
Might be a good exercise to do that (not sure how much effort it is to write a custom migrator), but based on the experience from smaller-scale renames with abseil & grpc, it would be possible to:
|
I had misinterpreted this as an "OR", but in any case, https://github.com/AnacondaRecipes/boost-feedstock does both the lib and the python bindings. The names are different from ours also for the python bindings:
|
Yes |
There's now a functioning draft for this: regro/cf-scripts#1668 |
This has been done in conda-forge/boost-feedstock#164, closing this |
Thanks Axel! 🙏 |
Pin all the way to the patch level as they include the patch version in the SONAME.
https://abi-laboratory.pro/index.php?view=timeline&l=boost
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)