-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pin for boost #3268
Update pin for boost #3268
Conversation
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/boost and so here I am doing that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Any objections to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to support both the current and this version for a while?
We have done this commonly in the past. |
i think that is desirable given it is a long migration. Is it any different than just adding two entries
|
No different. That's perfect! |
Why does boost not have a run export? |
I'm confused on that too. Many times it is header-only and so doesn't need one. |
I would rather users opt out of the pinning, rather than then opt-in, at least until we get a "boost header only package" |
We need to consult core. We've had this discussion before and there was not agreement. |
@conda-forge/core |
I think the comments below should be addressed first. |
In the past what we did is only support one version, but leave the migration running for a while until we could switch. That said, no strong feelings about this or other approaches |
See conda-forge/boost-cpp-feedstock#82. There was some discussion not too long ago about splitting between the header-only ouput and the full lib, where @isuruf said at the time:
|
I wasn't too involved, but I had the impression with 1.74 -> 1.78 that this wasn't actually as painful / longwinded as feared? It's not that long ago either (~3 month). |
As someone involved in that migration, it was fairly long running / painful. It also got coupled with the Python 3.11 migration, which made things tricky. Personally would be ok pushing off a Boost migration for a bit. Would be good to get some of the existing things off of our plates. |
Closing this as obsolete |
This PR has been triggered in an effort to update the pin for boost. The current pinned version is 1.74.0, the latest available version is 1.80.0 and the max pin pattern is x.x.x. This migration will impact 93 feedstocks.
Checklist:
**Please note that if you close this PR we presume that the new pin has been rejected.
@conda-forge-admin please ping boost
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2881043390, please use this URL for debugging