Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for boost #3268

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for boost. The current pinned version is 1.74.0, the latest available version is 1.80.0 and the max pin pattern is x.x.x. This migration will impact 93 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 1.74.0 to 1.80.0.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping boost
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2881043390, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner August 18, 2022 11:03
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/boost and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Aug 25, 2022
2 tasks
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2022

Any objections to this?

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to support both the current and this version for a while?

@beckermr
Copy link
Member

beckermr commented Dec 4, 2022

We have done this commonly in the past.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2022

i think that is desirable given it is a long migration. Is it any different than just adding two entries

boost:
- 1.78
- 1.80

@beckermr
Copy link
Member

beckermr commented Dec 4, 2022

No different. That's perfect!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2022

Why does boost not have a run export?

@beckermr
Copy link
Member

beckermr commented Dec 4, 2022

I'm confused on that too. Many times it is header-only and so doesn't need one.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2022

I'm confused on that too. Many times it is header-only and so doesn't need one.

I would rather users opt out of the pinning, rather than then opt-in, at least until we get a "boost header only package"

@beckermr
Copy link
Member

beckermr commented Dec 4, 2022

We need to consult core. We've had this discussion before and there was not agreement.

@beckermr
Copy link
Member

beckermr commented Dec 4, 2022

@conda-forge/core

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2022

I think the comments below should be addressed first.

@hmaarrfk hmaarrfk marked this pull request as draft December 4, 2022 20:12
@jakirkham
Copy link
Member

In the past what we did is only support one version, but leave the migration running for a while until we could switch. That said, no strong feelings about this or other approaches

@h-vetinari
Copy link
Member

We need to consult core. We've had this discussion before and there was not agreement.

See conda-forge/boost-cpp-feedstock#82.

There was some discussion not too long ago about splitting between the header-only ouput and the full lib, where @isuruf said at the time:

Only major thing we have to do is to write a migrator to go from boost-cpp -> libboost or boost-headers depending on if run had boost-cpp or not.

@h-vetinari
Copy link
Member

i think that is desirable given it is a long migration.

I wasn't too involved, but I had the impression with 1.74 -> 1.78 that this wasn't actually as painful / longwinded as feared? It's not that long ago either (~3 month).

@jakirkham
Copy link
Member

jakirkham commented Dec 14, 2022

As someone involved in that migration, it was fairly long running / painful. It also got coupled with the Python 3.11 migration, which made things tricky.

Personally would be ok pushing off a Boost migration for a bit. Would be good to get some of the existing things off of our plates.

@h-vetinari
Copy link
Member

Closing this as obsolete

@h-vetinari h-vetinari closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants