-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove std=c++14 from flags #75
Conversation
…nda-forge-pinning 2021.12.08.09.24.44
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I would also
|
Could you provide some details, why you consider to remove explicit std settings? As so we will use default behavior of clang-driver, which might get different for different versions. I agree that this way override of it via option gets more strict, but I might miss here something more interesting. |
This is based on @isuruf suggestion in #17 (comment) |
@isuruf Would you have time to look at this? I would be happy to bring this forward. |
@katietz, the issue with an explicit -std=c++14 is that it circumvents most build systems C++ setting. For some packages that need C++17, this forces them to use C++14. With clang 11, C++14 is the default, so this doesn't change anything for clang 11. However, it provides an easier way to use C++17 if a package needs it. |
@katietz, any thought on this? |
Ping @katietz |
Since I didn't hear from @katietz, going to assume this is okay. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing, but could not be merged (error=API error in POST to merge). |
thanks, got clear to me why. Sorry that I was a bit off, but had to do the 3.10 built out on Anaconda's side... I am fine with the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks for taking another look Kai! 😄 |
Fixes #17
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)