Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove std=c++14 from flags #75

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Dec 8, 2021

Fixes #17

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Dec 8, 2021

I would also

  • Backport this to 11.x
  • Build boost*=1.78 with this
  • Build a new abseil-cpp with this
  • Start the migration for both of them

@katietz
Copy link
Contributor

katietz commented Dec 8, 2021

Could you provide some details, why you consider to remove explicit std settings? As so we will use default behavior of clang-driver, which might get different for different versions. I agree that this way override of it via option gets more strict, but I might miss here something more interesting.

@xhochy
Copy link
Member Author

xhochy commented Dec 8, 2021

This is based on @isuruf suggestion in #17 (comment)

@xhochy
Copy link
Member Author

xhochy commented Dec 15, 2021

@isuruf Would you have time to look at this? I would be happy to bring this forward.

@isuruf
Copy link
Member

isuruf commented Jan 12, 2022

@katietz, the issue with an explicit -std=c++14 is that it circumvents most build systems C++ setting. For some packages that need C++17, this forces them to use C++14. With clang 11, C++14 is the default, so this doesn't change anything for clang 11. However, it provides an easier way to use C++17 if a package needs it.

@isuruf
Copy link
Member

isuruf commented Jan 18, 2022

@katietz, any thought on this?

@isuruf
Copy link
Member

isuruf commented Jan 25, 2022

Ping @katietz

@jakirkham
Copy link
Member

cc @anaconda-pkg-build

@isuruf
Copy link
Member

isuruf commented Feb 1, 2022

Since I didn't hear from @katietz, going to assume this is okay.

@isuruf isuruf added the automerge Merge the PR when CI passes label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing, but could not be merged (error=API error in POST to merge).

@katietz
Copy link
Contributor

katietz commented Feb 3, 2022

thanks, got clear to me why. Sorry that I was a bit off, but had to do the 3.10 built out on Anaconda's side... I am fine with the change

Copy link
Contributor

@katietz katietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@isuruf isuruf merged commit 4810f4f into conda-forge:master Feb 3, 2022
@jakirkham
Copy link
Member

Thanks for taking another look Kai! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using C++17
5 participants