Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for boost #1462

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for boost. The current pinned version is 1.74.0, the latest available version is 1.76.0 and the max pin pattern is x.x.x. This migration will impact 78 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 1.74.0 to 1.76.0.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping boost
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/808040834, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner May 3, 2021 22:30
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/boost and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@chrisburr chrisburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change macOS to use C++ 17 by default as part of this?

See: conda-forge/clang-compiler-activation-feedstock#17

@xhochy
Copy link
Member

xhochy commented May 4, 2021

Last time we had agreed on doing the boost migration for old and new version at the same time. I have updated it accordingly.

Reading conda-forge/clang-compiler-activation-feedstock#17 (comment) I'm not sure whether this would work and whether we failed to do the right thing in the boost update as we didn't increase the C++ standard over there.

@chrisburr
Copy link
Member

I'm not sure whether this would work and whether we failed to do the right thing in the boost update

We could mark the _0 macOS build as broken rather than waiting 6 months. It hasn't been downloaded much so I don't think it would cause much trouble.

@jakirkham
Copy link
Member

As noted in the other thread, added the C++17 issue to the agenda for the meeting tomorrow

@h-vetinari
Copy link
Member

conda-forge/clang-compiler-activation-feedstock#75 is in, so this should be unblocked now?

@izahn izahn mentioned this pull request Jul 11, 2022
2 tasks
@beckermr
Copy link
Member

Shall we jump ahead to 1.78 now?

@jakirkham
Copy link
Member

The feedstock is on 1.79.0. Would suggest going to that given there are other fixes that have been made to that and not prior releases

@beckermr
Copy link
Member

We only migrate even versions and have been only doing that for a while.

@beckermr
Copy link
Member

boost migrations tend to be very slow, reveal tons of breaks and bugs, and require lots of person power.

@jakirkham
Copy link
Member

Understand the need to do fewer migrations. Hence suggesting to go ahead with the newest version

Indeed we have had a convention of using even versions. However given it has been a while since we have updated Boost and we are planning to jump ahead. Would push for latest with needed fixes over following a convention that might not be best serving us in this instance

@h-vetinari
Copy link
Member

h-vetinari commented Jul 25, 2022

Would push for latest with needed fixes over following a convention that might not be best serving us in this instance

Agreed

(edit 1.80 is almost out, so it's not like we'd be jumping to the very cutting edge with 1.78...)

@jakirkham
Copy link
Member

Do you know when 1.80.0 is due?

@h-vetinari
Copy link
Member

Do you know when 1.80.0 is due?

Based on the patterns of previous releases in about 2 weeks. But I wouldn't go to 1.80 directly (basically no upstream will have tested compat yet, exacerbating the problems Matthew mentioned) - IMO 1.78 is safer.

@izahn
Copy link

izahn commented Aug 4, 2022

I think going to 1.78 makes sense. Is there anything blocking us from doing that in #2757 ?

@izahn
Copy link

izahn commented Aug 9, 2022

Any updates here @conda-forge/boost ? We need #2757 for rstudio updates.

@izahn
Copy link

izahn commented Aug 19, 2022

@conda-forge/core I would really appreciate an update here, we need boost>=1.78 for rstudio-feedstock updates.

@h-vetinari
Copy link
Member

There's now a bot-PR for 1.80: #3268

Given the concerns raised by Matthew (and the size of the bump 1.74->1.80 would be), I still think we should go with 1.78 in #2757.

@izahn
Copy link

izahn commented Sep 9, 2022

It looks like there is some consensus around going with 1.78. Can we go ahead and merge #2757 ?

@beckermr
Copy link
Member

beckermr commented Sep 9, 2022

closing since we went with 1.78.0

@beckermr beckermr closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants