Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a upper bound for rhash since 1.4.4 has SOVERSION change #531

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 30, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@isuruf isuruf requested a review from a team as a code owner August 30, 2023 20:57
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member

Lgtm! How do you like the new system?

@beckermr beckermr merged commit ce577ca into conda-forge:main Aug 30, 2023
2 checks passed
@isuruf
Copy link
Member Author

isuruf commented Aug 30, 2023

has_depends seems a bit limited, but other than that it works great. (Don't have the time to look into it any way)

@beckermr
Copy link
Member

beckermr commented Aug 30, 2023

Ah good feedback. Thank you!

We support glob syntax in has_depends (and basically all of the other selection fields) and one can use not_* to negate things. We also support has_constrains. This has covered most patches so far, but not all of them for sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants