Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed SONAME in 1.4.4 creates problems downstream #25

Closed
1 task done
zklaus opened this issue Aug 31, 2023 · 4 comments
Closed
1 task done

Changed SONAME in 1.4.4 creates problems downstream #25

zklaus opened this issue Aug 31, 2023 · 4 comments
Labels

Comments

@zklaus
Copy link

zklaus commented Aug 31, 2023

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

The SONAME change introduced in 1.4.4 creates problems downstream, see e.g. conda-forge/cmake-feedstock#192. Perhaps a migrator would be a good idea? Also repodata patches for downstream packages could be needed.

Installed packages

-

Environment info

-
@zklaus zklaus added the bug label Aug 31, 2023
@xylar
Copy link

xylar commented Aug 31, 2023

I believe we're seeing this in:
conda-forge/gdal-feedstock#803
conda-forge/netcdf-fortran-feedstock#84

At the very lease, these PRs are seeing issues with rhash that seem to be new since yesterday.

@zklaus
Copy link
Author

zklaus commented Aug 31, 2023

@xylar, I think you are right, but it is by proxy via Cmake. The latest Cmake build (which is only 1 hour old) should work, so I believe for the immediate problem it's enough to restart the ci.

@h-vetinari
Copy link
Member

Should we not raise an issue for this upstream? Why was the SONAME bumped in a patch release?

@zklaus
Copy link
Author

zklaus commented Sep 1, 2023

Hm. I guess as long as the project hasn't committed to a certain versioning strategy, there isn't really anything wrong with it, though it certainly is a bit surprising.

Anyway, I am gonna close this issue because @isuruf solved it with repodata patches. In fact he thought of the issue before it occurred and was careful enough to put the appropriate patch (conda-forge/conda-forge-repodata-patches-feedstock#531) in before making the SONAME/SOVERSION change. Unfortunately a small problem crept in which was then later rectified by conda-forge/conda-forge-repodata-patches-feedstock#533, so now all should be good.

@zklaus zklaus closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants