Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify recipe #205

Merged
merged 2 commits into from
Dec 6, 2023
Merged

simplify recipe #205

merged 2 commits into from
Dec 6, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Dec 4, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf mentioned this pull request Dec 4, 2023
Merged
10 tasks
@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 4, 2023

We had osx until last week 😊

bollwyvl
bollwyvl reviewed Dec 4, 2023
View reviewed changes
recipe/meta.yaml
@@ -29,18 +29,15 @@ requirements:
- python >=3.9
- setuptools >=51.0.0
run:
- __{{ noarch_platform }}
- __unix # [unix]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess at some point, the linter complained loudly about the presence of # [platform] selectors in noarch: python recipes.

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 4, 2023

@conda-forge-admin please rerender

@isuruf
Copy link
Member Author

isuruf commented Dec 4, 2023

Do you still want appnope included in osx?

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 4, 2023

appnope

It was dropped from this package upstream (still on ipykernel i think).

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 4, 2023

The as-reported hash_inputs look fine vs what's already up.

Is the CI linter substantially different from the local one?

@isuruf
Copy link
Member Author

isuruf commented Dec 4, 2023

Is the CI linter substantially different from the local one?

Nope. You need to have the conda-forge.yml file in place for the linter to not complain about selectors.

bollwyvl
bollwyvl approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple good!

@bollwyvl bollwyvl merged commit 5901b03 into conda-forge:main Dec 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollwyvl bollwyvl bollwyvl approved these changes

@Carreau Carreau Awaiting requested review from Carreau Carreau is a code owner

@blink1073 blink1073 Awaiting requested review from blink1073 blink1073 is a code owner

@ellisonbg ellisonbg Awaiting requested review from ellisonbg ellisonbg is a code owner

@fperez fperez Awaiting requested review from fperez fperez is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@minrk minrk Awaiting requested review from minrk minrk is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@takluyver takluyver Awaiting requested review from takluyver takluyver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isuruf @bollwyvl