-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vnu-validator 23.4.11 #24509
add vnu-validator 23.4.11 #24509
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ae5e1e9
to
79e4a94
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vnu-validator:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes @conda-forge/help-java ready for review |
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@xhochy of course |
@xhochy back to 💚 |
@conda-forge/staged-recipes @conda-forge/help-java still looking ✔️ here 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noarch_platform
work differently. They specify the OS where the CI is run on.
- unix # [osx] | ||
- unix # [linux] | ||
- win # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- unix # [osx] | |
- unix # [linux] | |
- win # [win] | |
- linux_64 | |
- win_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review!,
we'll get there over in conda-forge.yml
: here, it's being used as the name of __{virtual platform}
, as we only want to end up with 2 builds (unix
and win
).
This is adapted from ipython-feedstock
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's overly complicated. Here's a simplification of the ipython-feedstock. conda-forge/ipython-feedstock#205
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, tried that locally, getting:
recipes/vnu-validator/ has some lint:
`noarch` packages can't have selectors. If the selectors are necessary, please remove `noarch: generic`.
@@ -0,0 +1,3 @@ | |||
noarch_platforms: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't know you could do that on staged-recipes
🌟
Hm, now it looks like it's pulling some python metadata:
i guess if that's just the hash, that's fine, but hope my choice of scripting language didn't have a negative effect on the installability of this... |
Do I need to add some |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
lovely:
|
Welp, I have no further plans to change anything! Thanks for all the help! |
Thanks all! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).