Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vnu-validator 23.4.11 #24509

Merged
merged 18 commits into from
Dec 5, 2023
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Nov 16, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
    • I was not able to either build this from source, or find a feasible way to unravel all of the dependencies, much less their LICENSE texts

  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
    • the npmjs.org tarball was the simplest way to get just the .jar, and not a whole standalone app with bundled jdk

  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vnu-validator) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vnu-validator) and found some lint.

Here's what I've got...

For recipes/vnu-validator:

  • The requirements section contained an unexpected subsection name. ignore_run_exports is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vnu-validator) and found it was in an excellent condition.

@bollwyvl bollwyvl marked this pull request as ready for review November 16, 2023 18:34
@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-java ready for review

@bollwyvl
Copy link
Contributor Author

@xhochy of course CREDITS is not in the npm package, grumble, grumble...

@bollwyvl
Copy link
Contributor Author

@xhochy back to 💚

@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-java still looking ✔️ here 🤗

@bollwyvl bollwyvl requested a review from xhochy November 30, 2023 19:41
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noarch_platform work differently. They specify the OS where the CI is run on.

Comment on lines 2 to 4
- unix # [osx]
- unix # [linux]
- win # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- unix # [osx]
- unix # [linux]
- win # [win]
- linux_64
- win_64

Copy link
Contributor Author

@bollwyvl bollwyvl Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review!,

we'll get there over in conda-forge.yml: here, it's being used as the name of __{virtual platform}, as we only want to end up with 2 builds (unix and win).

This is adapted from ipython-feedstock:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's overly complicated. Here's a simplification of the ipython-feedstock. conda-forge/ipython-feedstock#205

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, tried that locally, getting:

recipes/vnu-validator/ has some lint:
  `noarch` packages can't have selectors. If the selectors are necessary, please remove `noarch: generic`.

@bollwyvl bollwyvl requested a review from xhochy December 4, 2023 21:45
@@ -0,0 +1,3 @@
noarch_platforms:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know you could do that on staged-recipes 🌟

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 4, 2023

Hm, now it looks like it's pulling some python metadata:

{
  "vnu-validator-23.4.11-h4f82c71": {
    "recipe": {
      "__unix": "__unix",
      "channel_targets": "conda-forge main",
      "python": "3.11.* *_cpython"
    }
  }
}

i guess if that's just the hash, that's fine, but hope my choice of scripting language didn't have a negative effect on the installability of this...

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 4, 2023

"python": "3.11.* *_cpython"

Do I need to add some ignore_run_exports or something?

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 4, 2023

lovely:

{
  "vnu-validator-23.4.11-h707e725": {
    "recipe": {
      "__unix": "__unix",
      "channel_targets": "conda-forge main"
    }
  }
}

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 4, 2023

Welp, I have no further plans to change anything! Thanks for all the help!

@xhochy xhochy merged commit 0ad0334 into conda-forge:main Dec 5, 2023
5 checks passed
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 6, 2023

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants