Build a headless opencv version #337

hmaarrfk · 2022-12-12T04:04:37Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2022-12-12T04:04:42Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices · 2023-01-15T03:17:06Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk · 2023-01-15T03:36:58Z

needs: conda-forge/qt-main-feedstock#100 (comment)

conda-forge-webservices · 2023-01-15T03:42:52Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

If python is a host requirement, it should be a run requirement.

hmaarrfk · 2023-01-15T04:03:16Z

@conda-forge-admin please rerender

conda-forge-webservices · 2023-01-15T04:04:06Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml

hmaarrfk · 2023-01-15T13:48:50Z

This is mostly really useful for those that want to start testing with qt6

hmaarrfk · 2023-01-15T13:52:36Z

@conda-forge/opencv thoughts on maintainability are appreciated.

hmaarrfk · 2023-01-15T19:34:18Z

@conda-forge-admin please rerender

hmaarrfk · 2023-01-15T19:37:40Z

Sorry it seems like there is still some work to do on windows.

hmaarrfk · 2023-01-15T22:24:10Z

@conda-forge-admin please rerender

hmaarrfk · 2023-01-16T02:47:28Z

@conda-forge-admin please rerender

recipe/meta.yaml

hmaarrfk · 2023-01-19T12:53:42Z

recipe/meta.yaml

    - liblapacke
    - liblapack
    - libcblas
    - freetype
-    - glib                           # [unix]
+    - glib


I don't think that glib is actually required:
conda-forge/conda-forge.github.io#1880

Tobias-Fischer · 2023-01-20T03:54:12Z

recipe/meta.yaml

+# Prioritize qt5 for noq over none and over qt6
+
+{% if qt_version == "5" %}
+{% set build = build + 400 %}


Should we use track_features instead?

The mamba way? that wasn't too popular in pytorch / tensorflow (i forget which). this is just "simpler" and easier to understand.

conda-forge/pytorch-cpu-feedstock#71

I remembered that @xhochy recently recommended using it: conda-forge/staged-recipes#21247

Tobias-Fischer · 2023-01-20T03:55:02Z

recipe/meta.yaml

@@ -96,21 +104,17 @@ requirements:
    # no quesitons about the license of the resulting opencv
    # binary
    - ffmpeg {{ ffmpeg }}=lgpl_*
-    - qt-main                             # [not osx and not ppc64le]
+    - qt-main     # [qt_version == 5]


Would != none be better, considering our move to qt6 at some point?

Honestly, my branch is called qt6 because i tried to get qt6 to work. I just couldn't, so i kinda "gave up" and reverted to this simpler one.

I see. All good then :)

Tobias-Fischer · 2023-01-20T03:55:46Z

I'm not a maintainer, but overall LGTM, just some minor suggestions.

hmaarrfk · 2023-01-23T03:26:39Z

@conda-forge-admin please rerender

…nda-forge-pinning 2023.01.23.01.26.33

hmaarrfk · 2023-01-23T03:37:06Z

@conda-forge-admin please rerender

…nda-forge-pinning 2023.01.23.01.26.33

hmaarrfk · 2023-01-23T13:56:05Z

@conda-forge-admin please rerender

…nda-forge-pinning 2023.01.23.01.26.33

hmaarrfk · 2023-02-03T02:18:45Z

I'm not convinced this is the right approach due to increased maintenance burden.

jan-janssen · 2023-05-31T16:21:08Z

@hmaarrfk What is the recommended approach for pypi packages which depend on opencv-python-headless ? Others like Intel provide such a package https://anaconda.org/intel/opencv-python-headless .

hmaarrfk · 2023-05-31T16:53:08Z

What is the recommended approach for pypi packages which depend on opencv-python-headless

pip install --no-deps package

is my only recommendation.

I'm not sure. I feel like opencv-python-headless is a workaround from the combined limitations of pypi and opencv. We have different limitations here which make me hesitant to merge something like this.

The main issue with pypi is that one package may depend on opencv-python and the other on opencv-python-headless.

This merge request (as it is) wouldn't make pypi find a locally installed version of opencv-python-headless and thus would not resolve your issue.

I would accept updates to this feedstock that make it look like a opencv-python-headless is installed along side with opencv-python.

Perhaps you can be inspired by:

https://github.com/conda-forge/opencv-feedstock/blob/main/recipe/install_pip_metadata.patch

I would ask that you add alot of skips when developing on the CIs for now. The build matrix for opencv is already quite huge.

jjerphan · 2023-10-05T17:17:38Z

Hi @hmaarrfk, thank you for this piece of work!

I might be able to help with packaging the equivalent of opencv-headless-python.

Is there a lot of work left? Would you be able to estimate the time it would take to finish it? Can I contribute to your efforts?

hmaarrfk · 2023-10-06T12:09:17Z

on the coding side, the answer is that it is "done".

the question I have is:

I do not want to use pup I'd strategy of having two packages with different names that end users need to choose which will clash when two of their dependencies choose opposite ones.
GUI support is not built as a plugin for open CV so it must be bundled in the python precompuled library. this is one technical thing that you might be able to submit patches for upstream

if you have ideas on how to deliver it to the wider audience I am glad to hear it.

personally, I see this request as quite niche, and those that require it can likely rebuild opencv using azure's free agents and upload the package to their channel. the package would be called opencv and simply not install the qt aspects for users that subscribe to your channel.

hmaarrfk requested review from hajapy, jakirkham, msarahan, ocefpaf, patricksnape and zym1010 as code owners December 12, 2022 04:04

hmaarrfk force-pushed the qt6 branch from 800c77a to a221e0a Compare January 15, 2023 03:17

hmaarrfk changed the title ~~Draft: Try to build Qt6~~ Draft: Build a headless opencv version Jan 15, 2023

hmaarrfk commented Jan 15, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

hmaarrfk mentioned this pull request Jan 15, 2023

Build with qt 5.9, 5.12, and no-qt #206

Closed

6 tasks

hmaarrfk force-pushed the qt6 branch 2 times, most recently from 26b53c8 to e8d6d30 Compare January 15, 2023 13:47

hmaarrfk changed the title ~~Draft: Build a headless opencv version~~ Build a headless opencv version Jan 15, 2023

hmaarrfk marked this pull request as draft January 15, 2023 19:37

hmaarrfk marked this pull request as ready for review January 16, 2023 02:47

hmaarrfk commented Jan 16, 2023

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

hmaarrfk commented Jan 19, 2023

View reviewed changes

Tobias-Fischer reviewed Jan 20, 2023

View reviewed changes

hmaarrfk added 7 commits January 22, 2023 22:25

Add builds for qt 5 and none (headless)

4806fcf

Try to see what is going on.

bd8108c

Add harfbuzz dependency was implicit before

7140e5d

Add glib dependency for windows, it was implicit before

1edf2e3

Unskip unix

29dd99e

Remove duplicate harfbuzz dependency

80ab542

harfbuzz only for linux

05d773e

hmaarrfk force-pushed the qt6 branch from 543cc56 to 05d773e Compare January 23, 2023 03:26

conda-forge-webservices[bot] and others added 2 commits January 23, 2023 03:31

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

0c16612

…nda-forge-pinning 2023.01.23.01.26.33

make glib unix only again

0809d76

conda-forge-webservices[bot] and others added 2 commits January 23, 2023 03:40

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

9684594

…nda-forge-pinning 2023.01.23.01.26.33

Add back harfbuzz and freetype

377ac85

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

b0483df

…nda-forge-pinning 2023.01.23.01.26.33

hmaarrfk marked this pull request as draft February 3, 2023 02:18

This was referenced Feb 3, 2023

Optionally build with ffmpeg because of patenting issues conda-forge/vtk-feedstock#282

Closed

Package transitions at conda-forge conda-forge/conda-forge.github.io#1894

Open

jjerphan mentioned this pull request Dec 19, 2023

[STU 192] - RFC - (Reactive) Blocks Developer Experience flojoy-ai/studio#982

Open

This was referenced Mar 10, 2024

Add opencv-python-headless conda-forge/staged-recipes#25669

Closed

Add headless options #396

Merged

hmaarrfk closed this in #396 Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build a headless opencv version #337

Build a headless opencv version #337

hmaarrfk commented Dec 12, 2022

conda-forge-linter commented Dec 12, 2022

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 16, 2023

hmaarrfk Jan 19, 2023

Tobias-Fischer Jan 20, 2023

hmaarrfk Jan 20, 2023

Tobias-Fischer Jan 20, 2023

Tobias-Fischer Jan 20, 2023

hmaarrfk Jan 20, 2023

Tobias-Fischer Jan 20, 2023

Tobias-Fischer commented Jan 20, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Feb 3, 2023

jan-janssen commented May 31, 2023

hmaarrfk commented May 31, 2023

jjerphan commented Oct 5, 2023 •

edited

Loading

hmaarrfk commented Oct 6, 2023

Build a headless opencv version #337

Build a headless opencv version #337

Conversation

hmaarrfk commented Dec 12, 2022

conda-forge-linter commented Dec 12, 2022

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

conda-forge-webservices bot commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 15, 2023

hmaarrfk commented Jan 16, 2023

hmaarrfk Jan 19, 2023

Choose a reason for hiding this comment

Tobias-Fischer Jan 20, 2023

Choose a reason for hiding this comment

hmaarrfk Jan 20, 2023

Choose a reason for hiding this comment

Tobias-Fischer Jan 20, 2023

Choose a reason for hiding this comment

Tobias-Fischer Jan 20, 2023

Choose a reason for hiding this comment

hmaarrfk Jan 20, 2023

Choose a reason for hiding this comment

Tobias-Fischer Jan 20, 2023

Choose a reason for hiding this comment

Tobias-Fischer commented Jan 20, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Jan 23, 2023

hmaarrfk commented Feb 3, 2023

jan-janssen commented May 31, 2023

hmaarrfk commented May 31, 2023

jjerphan commented Oct 5, 2023 • edited Loading

hmaarrfk commented Oct 6, 2023

jjerphan commented Oct 5, 2023 •

edited

Loading