Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opencv-python-headless #25669

Closed

Conversation

roaldarbol
Copy link
Contributor

Checklist

  • [ x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opencv-python-headless) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

See also conda-forge/opencv-feedstock#293 .

@synapticarbors
Copy link
Member

Looking through conda-forge/opencv-feedstock#293, given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with a separate feedstock for this? There have been other PRs that have needed this (e.g #25298). I'm not that familiar with OpenCV. Would another alternative be just to add a patch to the recipes that require the headless one to just grab the full version instead?

@traversaro
Copy link
Contributor

Looking through conda-forge/opencv-feedstock#293, given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with a separate feedstock for this? There have been other PRs that have needed this (e.g #25298). I'm not that familiar with OpenCV. Would another alternative be just to add a patch to the recipes that require the headless one to just grab the full version instead?

cc @conda-forge/opencv

@traversaro
Copy link
Contributor

traversaro commented Mar 10, 2024

Looking through conda-forge/opencv-feedstock#293, given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with a separate feedstock for this? There have been other PRs that have needed this (e.g #25298). I'm not that familiar with OpenCV. Would another alternative be just to add a patch to the recipes that require the headless one to just grab the full version instead?

Just to understand, what does "other PRs that have needed this" mean in this context? opencv-python is a superset of opencv-python-headless, so if the problem is just to ensure that pip check does not complain when it finds opencv-python and not opencv-python-headless, a possible solution is just to patch the upstream's setup.py to refer to opencv-python instead of opencv-python-headless.

fyi @tristanleduc given the comment in https://github.com/conda-forge/staged-recipes/pull/25298/files#r1513038826 .

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, such a package does not belong in conda-forge.

It is a necessity for pypi where shared libraries are very difficult, and vendoring is a must.

Fundementally speaking, this package clobbers the whole whole cv2 python namespace, and would fundamentally require collaboration with the opencv-feedstock to ensure that doesn't happen.

The main reason we didn't have a it before was that for years the opencv package was notoriously difficult to build and to maintain.

I'm willing to build a package that doesn't require qt. Honestly, its difficult to know if people want it, and care for it.

Its also been difficult to establish best practices with variants of packages with and without a feature.

Lets please discuss on the opencv-feedstock.

Please see this PR for history conda-forge/opencv-feedstock#337 , but do open an issue with your particular usecase so we can better help!

hmaarrfk added a commit to hmaarrfk/staged-recipes that referenced this pull request Mar 10, 2024
See conda-forge/opencv-feedstock#293
and more recent interest: conda-forge#25669

@conda-forge/qt-main requests for comments and thoughts is greatly
appreciated

@ocefpaf one of my concerns was about "maintainability" of this package.
It seems that the only way to update such a package is through repodata
patches. As such, I decided to create out of an abundance of caution a
noqt4 package. Let me know what you think.
Copy link

stale bot commented Aug 19, 2024

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Aug 19, 2024
@hmaarrfk
Copy link
Contributor

We’ve added configs to opencv to this.

@hmaarrfk hmaarrfk closed this Aug 19, 2024
hmaarrfk added a commit to hmaarrfk/staged-recipes that referenced this pull request Oct 12, 2024
See conda-forge/opencv-feedstock#293
and more recent interest: conda-forge#25669

@conda-forge/qt-main requests for comments and thoughts is greatly
appreciated

@ocefpaf one of my concerns was about "maintainability" of this package.
It seems that the only way to update such a package is through repodata
patches. As such, I decided to create out of an abundance of caution a
noqt4 package. Let me know what you think.
hmaarrfk added a commit to hmaarrfk/staged-recipes that referenced this pull request Oct 20, 2024
See conda-forge/opencv-feedstock#293
and more recent interest: conda-forge#25669

@conda-forge/qt-main requests for comments and thoughts is greatly
appreciated

@ocefpaf one of my concerns was about "maintainability" of this package.
It seems that the only way to update such a package is through repodata
patches. As such, I decided to create out of an abundance of caution a
noqt4 package. Let me know what you think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

4 participants