-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opencv-python-headless #25669
Add opencv-python-headless #25669
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
See also conda-forge/opencv-feedstock#293 . |
Looking through conda-forge/opencv-feedstock#293, given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with a separate feedstock for this? There have been other PRs that have needed this (e.g #25298). I'm not that familiar with OpenCV. Would another alternative be just to add a patch to the recipes that require the headless one to just grab the full version instead? |
cc @conda-forge/opencv |
Just to understand, what does "other PRs that have needed this" mean in this context? fyi @tristanleduc given the comment in https://github.com/conda-forge/staged-recipes/pull/25298/files#r1513038826 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, such a package does not belong in conda-forge.
It is a necessity for pypi where shared libraries are very difficult, and vendoring is a must.
Fundementally speaking, this package clobbers the whole whole cv2
python namespace, and would fundamentally require collaboration with the opencv-feedstock
to ensure that doesn't happen.
The main reason we didn't have a it before was that for years the opencv package was notoriously difficult to build and to maintain.
I'm willing to build a package that doesn't require qt. Honestly, its difficult to know if people want it, and care for it.
Its also been difficult to establish best practices with variants of packages with and without a feature.
Lets please discuss on the opencv-feedstock.
Please see this PR for history conda-forge/opencv-feedstock#337 , but do open an issue with your particular usecase so we can better help!
See conda-forge/opencv-feedstock#293 and more recent interest: conda-forge#25669 @conda-forge/qt-main requests for comments and thoughts is greatly appreciated @ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
We’ve added configs to opencv to this. |
See conda-forge/opencv-feedstock#293 and more recent interest: conda-forge#25669 @conda-forge/qt-main requests for comments and thoughts is greatly appreciated @ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.
See conda-forge/opencv-feedstock#293 and more recent interest: conda-forge#25669 @conda-forge/qt-main requests for comments and thoughts is greatly appreciated @ocefpaf one of my concerns was about "maintainability" of this package. It seems that the only way to update such a package is through repodata patches. As such, I decided to create out of an abundance of caution a noqt4 package. Let me know what you think.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).