Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdbm support (python 3.7) #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hmaarrfk
Copy link

Requires conda-forge/staged-recipes#6681

Closes #125

I got stuck doing something that required gdbm. I think that gdbm is required, so I decided to compile it.

I'll rerender after the package review to avoid noise in the commit.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -104,6 +106,10 @@ requirements:
#- vs2015_runtime # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be including gdbm at runtime?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOod question. My vote is no to keep GPL library out of the core dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An other reason would be to keep the python package lean. I'm sure there are many other options that could be added, but not everybody might need them. Since it wasn't really creating issues before, I assume that it is OK as is.

@jakirkham
Copy link
Member

Have restarted CIs now that gdbm has been added.

@hmaarrfk
Copy link
Author

I noticed pypy was built with gdbm. Do we need to defender it?

@hmaarrfk hmaarrfk closed this Sep 21, 2018
@hmaarrfk hmaarrfk reopened this Sep 21, 2018
@hmaarrfk
Copy link
Author

OMG. So sorry. I clicked the wrong button ...

@jakirkham
Copy link
Member

All good.

Possibly. Maybe we should raise an issue on the PyPy feedstocks and see.

@hmaarrfk
Copy link
Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor

jjhelmus commented Oct 3, 2018

Rather than creating a build of Python with the gdbm module what if a separate package was created that contained the _gdbm.so file in the lib-dyload or equivalent directory. Installing this package would enable the use of of the dbm.gnu module. This would nicely separation the GPL components.

This requires that the code that build be extension be extracted out the setup.py file in the Python source code but I'd be happy to help with this.

@hmaarrfk
Copy link
Author

hmaarrfk commented Oct 3, 2018

@jjhelmus I would be in favor of that

Honestly, I was just going to create the same python package but omit the strict dependency on the gdbm package.

But to your idea, could we simply create a split package where by one output, python-gdbm just copies lib/python3.7/lib-dynload/_gdbm.cpython-37m-x86_64-linux-gnu.so into the prefix, while
python calls make install and removes the file lib/python3.7/lib-dynload/_gdbm.cpython-37m-x86_64-linux-gnu.so

@h-vetinari
Copy link
Member

Any update on this effort? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building gdbm support
5 participants