Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gdbm support (python 3.7) #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add gdbm support (python 3.7) #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97dde01
Add gdbm support (python 3.7)
hmaarrfk Sep 16, 2018
52bc420
Bump the build number
hmaarrfk Sep 16, 2018
6ace868
MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.09.27
hmaarrfk Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ environment:
secure: tumuXLL8PU75WMnRDemRy02ruEq2RpNxeK3dz0MjFssnosPm2v4EFjfNB4PTotA1

matrix:
- CONFIG: win_c_compilervs2015cxx_compilervs2015vc14
- CONFIG: win_c_compilervs2015cxx_compilervs2015target_platformwin-64vc14
CONDA_INSTALL_LOCN: C:\Miniconda36-x64


Expand Down
2 changes: 2 additions & 0 deletions ...t/linux_c_compilergcccxx_compilergxx.yaml → ...x_compilergxxtarget_platformlinux-64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ readline:
- '7.0'
sqlite:
- '3'
target_platform:
- linux-64
tk:
- '8.6'
xz:
Expand Down
2 changes: 2 additions & 0 deletions ...toolchain_ccxx_compilertoolchain_cxx.yaml → ...toolchain_cxxtarget_platformlinux-64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ readline:
- '7.0'
sqlite:
- '3'
target_platform:
- linux-64
tk:
- '8.6'
xz:
Expand Down
2 changes: 2 additions & 0 deletions ...x_c_compilerclangcxx_compilerclangxx.yaml → ...compilerclangxxtarget_platformosx-64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ readline:
- '7.0'
sqlite:
- '3'
target_platform:
- osx-64
tk:
- '8.6'
xz:
Expand Down
2 changes: 2 additions & 0 deletions ...toolchain_ccxx_compilertoolchain_cxx.yaml → ...ertoolchain_cxxtarget_platformosx-64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ readline:
- '7.0'
sqlite:
- '3'
target_platform:
- osx-64
tk:
- '8.6'
xz:
Expand Down
2 changes: 2 additions & 0 deletions ...compilervs2015cxx_compilervs2015vc14.yaml → ...pilervs2015target_platformwin-64vc14.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ pin_run_as_build:
max_pin: x
vc:
max_pin: x
target_platform:
- win-64
vc:
- '14'
zip_keys:
Expand Down
24 changes: 12 additions & 12 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
version: 2

jobs:
build_linux_c_compilergcccxx_compilergxx:
build_linux_c_compilergcccxx_compilergxxtarget_platformlinux-64:
working_directory: ~/test
machine: true
environment:
- CONFIG: "linux_c_compilergcccxx_compilergxx"
- CONFIG: "linux_c_compilergcccxx_compilergxxtarget_platformlinux-64"
steps:
- checkout
- run:
Expand All @@ -18,11 +18,11 @@ jobs:
- run:
# Run, test and (if we have a BINSTAR_TOKEN) upload the distributions.
command: ./.circleci/run_docker_build.sh
build_linux_c_compilertoolchain_ccxx_compilertoolchain_cxx:
build_linux_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformlinux-64:
working_directory: ~/test
machine: true
environment:
- CONFIG: "linux_c_compilertoolchain_ccxx_compilertoolchain_cxx"
- CONFIG: "linux_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformlinux-64"
steps:
- checkout
- run:
Expand All @@ -35,12 +35,12 @@ jobs:
- run:
# Run, test and (if we have a BINSTAR_TOKEN) upload the distributions.
command: ./.circleci/run_docker_build.sh
build_osx_c_compilerclangcxx_compilerclangxx:
build_osx_c_compilerclangcxx_compilerclangxxtarget_platformosx-64:
working_directory: ~/test
macos:
xcode: "9.0"
environment:
- CONFIG: "osx_c_compilerclangcxx_compilerclangxx"
- CONFIG: "osx_c_compilerclangcxx_compilerclangxxtarget_platformosx-64"
steps:
- checkout
- run:
Expand All @@ -51,12 +51,12 @@ jobs:
- run:
# Run, test and (if we have a BINSTAR_TOKEN) upload the distributions.
command: ./.circleci/run_osx_build.sh
build_osx_c_compilertoolchain_ccxx_compilertoolchain_cxx:
build_osx_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformosx-64:
working_directory: ~/test
macos:
xcode: "9.0"
environment:
- CONFIG: "osx_c_compilertoolchain_ccxx_compilertoolchain_cxx"
- CONFIG: "osx_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformosx-64"
steps:
- checkout
- run:
Expand All @@ -72,7 +72,7 @@ workflows:
version: 2
build_and_test:
jobs:
- build_linux_c_compilergcccxx_compilergxx
- build_linux_c_compilertoolchain_ccxx_compilertoolchain_cxx
- build_osx_c_compilerclangcxx_compilerclangxx
- build_osx_c_compilertoolchain_ccxx_compilertoolchain_cxx
- build_linux_c_compilergcccxx_compilergxxtarget_platformlinux-64
- build_linux_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformlinux-64
- build_osx_c_compilerclangcxx_compilerclangxxtarget_platformosx-64
- build_osx_c_compilertoolchain_ccxx_compilertoolchain_cxxtarget_platformosx-64
7 changes: 6 additions & 1 deletion recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ source:
sha256: de3c87b26a80e789986d8e6950c6304175d3829afe9c6c7211eb7257266ab0ac # [win]

build:
number: 1004
number: 1005
# Windows has issues updating python if conda is using files itself.
# Copy rather than link.
no_link:
Expand Down Expand Up @@ -101,6 +101,7 @@ requirements:
- zlib # [unix]
- ncurses # [linux]
- libffi # [unix]
- gdbm # [unix]
run:
- openssl # [unix]
- readline # [unix]
Expand All @@ -113,6 +114,10 @@ requirements:
#- vs2015_runtime # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be including gdbm at runtime?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOod question. My vote is no to keep GPL library out of the core dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An other reason would be to keep the python package lean. I'm sure there are many other options that could be added, but not everybody might need them. Since it wasn't really creating issues before, I assume that it is OK as is.


test:
requires: # [unix]
- gdbm # [unix]
imports: # [unix]
- dbm.gnu # [unix]
commands:
- python -V
- python3 -V # [unix]
Expand Down