Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray-packages v2.1.0 #78

Merged
merged 19 commits into from
Nov 18, 2022

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #76

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
openjdk 19.0.1 Anaconda-Server Badge
ray-packages 2.1.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3416647520, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@h-vetinari
Copy link
Member

h-vetinari commented Nov 8, 2022

This will have to wait for #77. Once ready, we also need to unpin grpc completely. The previous problems were solved by ray-project/ray#28354, though upstream stayed conservative with a <=1.48.1 pin. However, conda-forge is already on 1.49 (and 1.50 is out already), so to avoid resolvability issues (and in the absence of strong reasons like there were previously), we should unpin grpc, at the very least to include 1.49.

Edit: NVM, the cap was explicitly lifted in ray-project/ray@9505cd1

@h-vetinari h-vetinari marked this pull request as draft November 8, 2022 07:43
@h-vetinari h-vetinari marked this pull request as draft November 8, 2022 07:43
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ray-packages-feedstock/actions/runs/3418176799.

@h-vetinari
Copy link
Member

@mattip @vnlitvinov
FYI, The redis-patch needs updating yet again... 😑

@h-vetinari
Copy link
Member

@vnlitvinov
I reworked the redis-patch to build on top of the existing one in the ray sources. I think that makes for a much more readable patch, see e.g. here. I've also taken your suggestion to update ray-patching.md.

PTAL

PS. I'd like to fix the OSX (see #80) before we merge this.

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the test failure is related to inability to start workers. Further up there is

ERROR services.py:1403 -- Failed to start the dashboard: \
    Failed to start the dashboard, return code -11

Maybe there is something off elsewhere?

ray-patching.md Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@mattip
Copy link
Contributor

mattip commented Nov 9, 2022

In order to separate dashboard failures from other issues, could you add a test

- python -c "import ray; ray.init(include_dashboard=False)"

before this line

- python -c "import ray; ray.init()"

@h-vetinari
Copy link
Member

h-vetinari commented Nov 14, 2022

I tried to follow up an unlikely gut-feeling, and it seems indeed that a patch-version of protobuf might have broken things. In particular, things break with 4.21.9 but run through with 4.21.6 (in both cases with grpc 1.49.1)

@h-vetinari
Copy link
Member

I tried to follow up an unlikely gut-feeling, and it seems indeed that a patch-version of protobuf might have broken things. In particular, things break with 4.21.9 but run through with 4.21.6 (in both cases with grpc 1.49.1)

Nevermind, pinning protobuf seems to have backed the resolver into some weird corners. Let's try again even more explicitly.

@vnlitvinov
Copy link
Contributor

xref modin-project/modin#5208 also with Ray 2.1.0 (from pip, but other deps from conda-forge).
Seems like some dependencies are bad.

@h-vetinari
Copy link
Member

OK, I wasn't thinking that the host-dep-at-build-time gets picked up as a lower bound, so grpcio 1.49.1 + protobuf 4.21.6 is impossible to co-install (grpc was built against libprotobuf 3.21.9, meaning it needs >=3.21.9 at runtime; this corresponds to protobuf 4.21.9 after protobuf's recent versioning scheme change)

@mattip
Copy link
Contributor

mattip commented Nov 14, 2022

What would you think about extending the summary to mention all the different packages provided to make the summary at the various links like https://anaconda.org/conda-forge/ray-default more informative? I would like to link to it from https://docs.ray.io/en/latest/ray-overview/installation.html#installing-ray-with-anaconda as part of reworking that documentation stanza.

    - licenses/redis-hiredis-COPYING.txt
     - licenses/tporadowski-redis-license.txt
     - licenses/zlib-LICENSE.txt
-  summary: Ray is a fast and simple framework for building and running distributed applications.
+  summary: |
+    Ray is a fast and simple framework for building and running distributed
+    applications. It is split into ray-core, ray-default, ray-dashboard,
+    ray-serve, ray-rllib, ray-k8s, ray-data, ray-tune, and ray-all packages.
   description: |
     Ray is a fast and simple framework for building and running
     distributed applications.

@h-vetinari
Copy link
Member

What would you think about extending the summary

Fine by me, though personally I'd extend the description rather than the summary (no strong preference however).

@h-vetinari
Copy link
Member

Do we want to publish this with a pin for grpcio<1.49 for the moment?

@mattip
Copy link
Contributor

mattip commented Nov 16, 2022

A pin sounds like the most practical solution indeed.

@mattip mattip marked this pull request as ready for review November 17, 2022 17:34
@mattip
Copy link
Contributor

mattip commented Nov 17, 2022

CI is passing. I will merge tomorrow if there are no objections.

Copy link
Contributor

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, though I would like to mimic dependencies from setup.py in a more close manner.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion left, can go without if you wish. Thanks!

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattip mattip added the automerge Merge the PR when CI passes label Nov 18, 2022
@github-actions github-actions bot merged commit 7192818 into conda-forge:main Nov 18, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.1.0_hc778b5 branch November 18, 2022 10:37
mattip pushed a commit to mattip/ray-packages-feedstock that referenced this pull request Nov 18, 2022
automerged PR by conda-forge/automerge-action
@h-vetinari h-vetinari mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants