Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#5253: Upgrade pandas to 1.5.2 #5254

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Nov 23, 2022

Signed-off-by: Igoshev, Iaroslav iaroslav.igoshev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Upgrade pandas to 1.5.2 #5253
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

environment-dev.yml Outdated Show resolved Hide resolved
@YarShev YarShev marked this pull request as ready for review November 23, 2022 13:25
@YarShev YarShev requested a review from a team as a code owner November 23, 2022 13:25
mvashishtha
mvashishtha previously approved these changes Nov 23, 2022
Comment on lines 44 to 46
# TODO(https://github.com/modin-project/modin/issues/5256): Move pandas back
# to installation with conda
- pandas==1.5.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like plain wrong. This should be investigated (for example, we won't be able to make a conda-forge release doing things like that).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what you mean by "plain wrong". We have already been installing Ray, for instance, from PyPI in environment-dev.yml. I do not see anything bad if we install pandas from PyPI for now in order not to stop making the release in PyPI. While we are preparing the release for PyPI, we can investigate the issue in backgroung and when we come to the release in conda-forge, the issue might already be resolved. Created conda-incubator/setup-miniconda#264. So I propose to merge the changes as is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the fact that we mix things from pip and conda is causing us issues already - #5208 (probable cause explained around conda-forge/ray-packages-feedstock#78 (comment)).

Plus it means we're not testing what our typical end user is installing, I think most customers use either pip or conda but not a semi-random mix.

Copy link
Collaborator Author

@YarShev YarShev Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we shouldn't mix things from pip and conda but we have been doing that for a quite a long time (e.g., Ray). The fact we currenlty install pandas from conda and Ray from pip doesn't guarantee the correctness of Modin as we don't test this. Here is the similar case. My proposals are

  1. Merge the changes as is.
  2. Wait for a response in nothing provides requested pandas 1.5.2 conda-incubator/setup-miniconda#264 or BUILD: pandas 1.5.2 can't be installed with conda-incubator/setup-miniconda@v2 pandas-dev/pandas#49894.

If you have anything else, you're welcome.

I tried to use channels option for conda-incubator/setup-miniconda@v2 in GH Actions to specify conda-forge manually and it didn't work.
I tried to remove pandas from the file and install it manually with conda install pandas=1.5.2 -c conda-forge in GH Actions. It didn't work too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I returned back pandas to installation with conda. See more about the fix in conda-incubator/setup-miniconda#264.

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, awesome you've figured it our @YarShev!

@vnlitvinov vnlitvinov merged commit 8f6e642 into modin-project:master Nov 25, 2022
dchigarev pushed a commit that referenced this pull request Nov 25, 2022
* Set use-only-tar-bz2 to false

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev YarShev deleted the dev/yigoshev-issue5253 branch November 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pandas to 1.5.2
3 participants