Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: remove double dependency on dask core #30

Closed
wants to merge 3 commits into from

Conversation

hmaarrfk
Copy link
Contributor

Remove double dependency on dask

- Remove build dep on numpy doc
- Add cytoolz as a dependency for speed
- Update build command

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: ensure dependencies are update MNT: remove double dependency on dask core Sep 30, 2018
@hmaarrfk hmaarrfk force-pushed the dask_dependency branch 2 times, most recently from f1dcd78 to 7ff5c8f Compare September 30, 2018 05:03
@hmaarrfk
Copy link
Contributor Author

@ocefpaf I have no idea why appveyor is failing. something about pip?

https://ci.appveyor.com/project/conda-forge/scikit-image-feedstock/build/1.0.115/job/u9rh9ilhm03bhlj2#L1126

- Remove build dep on numpy doc
- Add cytoolz as a dependency for speed
- Update build command
@ocefpaf
Copy link
Member

ocefpaf commented Sep 30, 2018

@hmaarrfk I think it may be an issue with the latest Python in Windows b/c I saw similar errors on other compiled extensions that were working not long ago, like basemap here:

conda-forge/basemap-feedstock#34

@scopatz and @mariusvniekerk are actively working on the Python packages and can probably comment more on this.

@hmaarrfk
Copy link
Contributor Author

@ocefpaf got it. the celiagg feedstock was giving similar errors. I'll just wait.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 2, 2018

Removed in favour of #33

@hmaarrfk hmaarrfk closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants