MNT: Remove double dependency on dask #33
Conversation
- Remove build dep on numpy doc - Add cytoolz as a dependency for speed - Update build command
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -37,12 +36,14 @@ requirements: | |||
| - matplotlib >=2.0.0 | |||
| - networkx >=1.8 | |||
| - pillow >=4.3.0 | |||
| - dask-core >=0.15 | |||
There was a problem hiding this comment.
Oh, in this iteration i decided that 0.9 was the correct version choice ;)
There was a problem hiding this comment.
For reference, 0.15.2 was the first release that included dask-core IIRC. Hence why it was used as the lower bound here.
| - toolz >=0.7.4 | ||
| - pywavelets >=0.4.0 | ||
| - dask-core >=0.9.0 | ||
| - cloudpickle >=0.2.1 | ||
| - imageio >=2.1.0 | ||
| # scikit-image depends on dask-array | ||
| # which requires numpy, dask-core and toolz (cytoolz for speed) | ||
| - cytoolz >=0.7.3 |
There was a problem hiding this comment.
I don't know whether it's a good idea include Cytoolz... Doesn't this go against your philosophy of making a minimal package?
There was a problem hiding this comment.
I'm mostly for "having choice to create a minimal package if I want to". I don't care for example if xarray installs 100 things, but I want to be able to depend on xarray-core
- cytoolz is basically faster toolz.
- The only dependency ctoolz has is toolz.
conda-forge is about having things work well out of the box. I think cytoolz hits that "just right"
There was a problem hiding this comment.
This is probably my fault for not reviewing PR ( conda-forge/dask-feedstock#49 ) sooner. I've take a look and it seems basically fine. Maybe that will make things more straightforward here.
|
@jni, maybe we should wait for conda-forge/matplotlib-feedstock#178 to get pulled in so we can depend on |
|
@jni, doesn't seem so obvious how we would depend on |
|
Is anything preventing merging this? It looks good to me FWIW. |
|
I think @jni is just swamped and this is low priority. |
|
Sure, that not an issue, but I'm hoping one of the other recipes maintainers might be willing to press the green button :) It's a fairly non controversial PR.. |
|
It's not entirely non-controversial to add a new dependency. But whatever, by popular demand, I'm merging. =D |
Related to #32