Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for calver and trove-classifiers #21504

Merged
merged 2 commits into from
Dec 11, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Dec 10, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/calver, recipes/trove-classifiers) and found some lint.

Here's what I've got...

For recipes/trove-classifiers:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@xylar xylar changed the title Add trove classifiers Add recipe for calver and trove-classifiers Dec 10, 2022
@xylar xylar force-pushed the add-trove-classifiers branch from c361ea8 to 0d2bcee Compare December 10, 2022 21:48
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/calver, recipes/trove-classifiers) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Dec 10, 2022

@conda-forge/help-python, while OSX and Win tests are still running, I believe Linux test having passed indicate that this is ready for review.

@hmaarrfk hmaarrfk merged commit 1285f26 into conda-forge:main Dec 11, 2022
@xylar
Copy link
Contributor Author

xylar commented Dec 11, 2022

@hmaarrfk, thank you!

@xylar xylar deleted the add-trove-classifiers branch December 11, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants