poetry v1.3.0 #77

regro-cf-autotick-bot · 2022-12-10T02:01:23Z

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #72
Closes: #73
Closes: #74

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
poetry-core	1.4.0

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

dulwich
urllib3
autovizwidget
platformdirs
filelock

Packages found in the meta.yaml but not found by source code inspection:

clikit
cachy
ptyprocess

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3661965370, please use this URL for debugging.}

…nda-forge-pinning 2022.12.09.20.17.28

conda-forge-linter · 2022-12-10T02:01:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter · 2022-12-10T21:13:04Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

requirements: run: cachecontrol = >=0.12.9,<0.13 should not contain a space between relational operator and the version, i.e. cachecontrol =>=0.12.9,<0.13

conda-forge-linter · 2022-12-10T21:14:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar · 2022-12-10T21:14:35Z

@conda-forge-admin, please rerender

xylar · 2022-12-10T21:15:31Z

@ocefpaf and @maresb, please have a careful look. There are a lot of dependency changes here and I think we can't get away with noarch anymore.

…nda-forge-pinning 2022.12.10.21.07.48

xylar · 2022-12-10T21:24:00Z

conda-forge/poetry-plugin-export-feedstock#8 and conda-forge/poetry-plugin-export-feedstock#9 went to poetry_dev instead of main and need to be rebuilt for main.

Need to wait for a poetry-core 1.4.0 build

trove-classifiers (https://pypi.org/project/trove-classifiers/) has not been built on conda-forge and needs a staged recipe.

xylar · 2022-12-10T21:38:22Z

regarding poetry-plugin-export:
conda-forge/poetry-plugin-export-feedstock#11
conda-forge/poetry-plugin-export-feedstock#12

xylar · 2022-12-10T21:49:55Z

Regarding trove-classifiers:
conda-forge/staged-recipes#21504

recipe/meta.yaml

xylar · 2022-12-10T22:15:55Z

recipe/meta.yaml

+    - tomlkit >=0.11.1,<1.0.0,!=0.11.2,!=0.11.3
+    - trove-classifiers >=2022.5.19
+    - virtualenv >=20.4.3,<21.0.0,!=20.4.5,!=20.4.6  # [not win or py!=39]
+    - xattr >=0.10.0,<0.11.0  # [darwin]


This is the one I see no way around -- we can't be noarch.

Does installing xattr break non-osx?

Yes, xattr doesn't exist for win:
https://github.com/conda-forge/xattr-feedstock/blob/main/recipe/meta.yaml#L16

And I would hesitate to override the upstream choices in general to too great a degree.

xylar · 2022-12-10T22:17:47Z

recipe/meta.yaml

    - html5lib >=1.0,<2.0
-    - shellingham >=1.1,<2.0
-    - tomlkit >=0.7.0,<1.0.0
+    - importlib-metadata >=4.4,<5.0  # [py<310]


This could be noarch if everything else could be.

Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>

xylar · 2022-12-11T08:24:48Z

Regarding poetry-core:
conda-forge/poetry-core-feedstock#35

recipe/meta.yaml

Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>

maresb · 2022-12-11T10:01:42Z

recipe/meta.yaml

+    # `poetry` entry point fails without this:
+    - lockfile >=0.9


I understand that this is necessary, but I'm confused how Poetry works when this isn't an explicit dependency. Do you understand where it's coming from? Maybe there is a missing dependency from filelock or something?

I reported this upstream in python-poetry/poetry#7171. Let's see what they say.

I also think it's a problem regardless of whether this should come from another dependency because it's an explicit dependency.

Good point, explicit dependencies should definitely be included by the package using them. But it's probably also an implicit dependency which is missing somewhere on CF... I can try to have a look...

xylar · 2022-12-11T10:56:15Z

export SRC_DIR=/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work
/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work/conda_build.sh: line 4: /Users/runner/miniforge3/conda-bld/poetry_1670754476345/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin/python: Bad CPU type in executable

Any ideas?

maresb · 2022-12-11T11:04:15Z

I suspect we're missing something from cross-compilation on arm64. We should be able to compare with some other generic recipe with osx-arm64 enabled. I have to go right now, be back in an hour or so.

xylar · 2022-12-11T11:47:16Z

Perfect, thanks @maresb!

xylar

Seems ready. I'll automerge.

xylar

Seems ready. I'll automerge.

maresb · 2022-12-11T12:27:51Z

Huh? What's going on? Our commits here have landed in main ~~without a merge commit~~, and this PR is still open.

EDIT: Sorry, I seem to have been confused. I think I was looking at the file history, there is a merge commit.

maresb · 2022-12-11T12:34:35Z

While the automerge action was running, there was a 500 failure in the GH API call to the merge endpoint.

I can open a PR in the automerge repo to try and give a better stack trace. Perhaps for here we should run @conda-forge-admin, please rerun bot to clear things up and see where that leaves us. Then if there's no build, open a new PR with an empty commit?

maresb · 2022-12-11T12:34:55Z

Ah, crap! I meant to remove the @

maresb · 2022-12-11T12:49:28Z

BTW I tracked down the implicit lockfile dependency to conda-forge/cachecontrol-feedstock#15. That was really confusing, since I wasn't expecting a yanked package!

automerged PR by conda-forge/automerge-action

maresb · 2022-12-11T13:10:41Z

I just reset the head on main. Let's merge this by hand after checks pass, and then I'll open a PR in conda-forge/automerge-action.

xylar · 2022-12-11T14:04:03Z

then I'll open a PR in conda-forge/automerge-action.

That's not what I had in mind and not safe here. The automerge bot is only for recipes where the dependencies very rarely change. I just wanted to automerge this particular PR, but no need now

maresb · 2022-12-11T14:10:28Z

Thanks for merging!

I think I wasn't clear about what I meant in my previous message. I wasn't proposing enabling automerge here. Rather, I noticed a bug in the stack trace of the automerge-action which I'd like to fix with a PR.

xylar · 2022-12-11T14:15:19Z

Sorry, I misunderstood. I see that now what you meant. The risks of girhubbing with my phone...

BastianZim · 2022-12-15T16:48:41Z

If the only reason this isn't noarch anymore is dependencies, you could do something like outlined here: conda-forge/conda-forge.github.io#1839

xylar · 2022-12-15T19:19:06Z

We can give that a try. It would certainly be nice to go back to to noarch.

BastianZim · 2022-12-15T22:38:45Z

Great, I’ll make a PR tomorrow

BastianZim · 2022-12-16T12:15:33Z

Do we know if it's safe to install tomli everywhere, including 3.11?

xylar · 2022-12-16T13:52:37Z

Do we know if it's safe to install tomli everywhere, including 3.11?

Looking into it...

xylar · 2022-12-16T13:54:35Z

I looks like it. tomli is noarch on conda-forge and doesn't exclude 3.11. Then, there are these lines in poetry:
https://github.com/python-poetry/poetry/blob/1.3.0/src/poetry/utils/_compat.py#L11-L15
So it just won't get used in py 3.11.

regro-cf-autotick-bot added 2 commits December 10, 2022 02:01

updated v1.3.0

7609c3e

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

56edea6

…nda-forge-pinning 2022.12.09.20.17.28

regro-cf-autotick-bot requested review from maresb, ocefpaf and xylar as code owners December 10, 2022 02:01

Update dependencies and drop noarch:python

a21c81e

Fix typo

e0396e6

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

169bab5

…nda-forge-pinning 2022.12.10.21.07.48

maresb requested changes Dec 10, 2022

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

xylar reviewed Dec 10, 2022

View reviewed changes

Fix virtualenv

d312cf1

Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>

maresb reviewed Dec 11, 2022

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

xylar and others added 2 commits December 11, 2022 10:56

explain xattr

fd34da2

Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>

Add lockfile dependency

59e2ce8

maresb reviewed Dec 11, 2022

View reviewed changes

Fix darwin-->osx (hopefully)

6110546

maresb approved these changes Dec 11, 2022

View reviewed changes

Readd requirements.build with cross-python

0c177e0

xylar approved these changes Dec 11, 2022

View reviewed changes

xylar added the automerge Merge the PR when CI passes label Dec 11, 2022

conda-forge-linter added the bot-rerun Instruct the bot to retry the PR label Dec 11, 2022

maresb removed the bot-rerun Instruct the bot to retry the PR label Dec 11, 2022

maresb pushed a commit to maresb/poetry-feedstock that referenced this pull request Dec 11, 2022

poetry v1.3.0 (conda-forge#77)

abde908

automerged PR by conda-forge/automerge-action

maresb closed this Dec 11, 2022

maresb reopened this Dec 11, 2022

maresb removed the automerge Merge the PR when CI passes label Dec 11, 2022

xylar merged commit 84ff470 into conda-forge:main Dec 11, 2022

maresb mentioned this pull request Dec 11, 2022

How to install the development version of Poetry #64

Closed

regro-cf-autotick-bot deleted the 1.3.0_h5f1e7e branch December 11, 2022 14:16

BastianZim mentioned this pull request Dec 16, 2022

Make noarch #80

Merged

5 tasks

poetry v1.3.0 #77

poetry v1.3.0 #77

Conversation

regro-cf-autotick-bot commented Dec 10, 2022 • edited by xylar Loading

Pending Dependency Version Updates

Dependency Analysis

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

conda-forge-linter commented Dec 10, 2022

conda-forge-linter commented Dec 10, 2022

conda-forge-linter commented Dec 10, 2022

xylar commented Dec 10, 2022

xylar commented Dec 10, 2022

xylar commented Dec 10, 2022 • edited Loading

xylar commented Dec 10, 2022

xylar commented Dec 10, 2022

xylar Dec 10, 2022

Choose a reason for hiding this comment

maresb Dec 10, 2022

Choose a reason for hiding this comment

xylar Dec 11, 2022

Choose a reason for hiding this comment

xylar Dec 10, 2022 • edited Loading

Choose a reason for hiding this comment

xylar commented Dec 11, 2022

maresb Dec 11, 2022

Choose a reason for hiding this comment

xylar Dec 11, 2022

Choose a reason for hiding this comment

maresb Dec 11, 2022

Choose a reason for hiding this comment

xylar commented Dec 11, 2022

maresb commented Dec 11, 2022

xylar commented Dec 11, 2022

xylar left a comment

Choose a reason for hiding this comment

xylar left a comment

Choose a reason for hiding this comment

maresb commented Dec 11, 2022 • edited Loading

maresb commented Dec 11, 2022

maresb commented Dec 11, 2022

maresb commented Dec 11, 2022

maresb commented Dec 11, 2022 • edited Loading

xylar commented Dec 11, 2022

maresb commented Dec 11, 2022

xylar commented Dec 11, 2022

BastianZim commented Dec 15, 2022

xylar commented Dec 15, 2022

BastianZim commented Dec 15, 2022

BastianZim commented Dec 16, 2022

xylar commented Dec 16, 2022

xylar commented Dec 16, 2022

regro-cf-autotick-bot commented Dec 10, 2022 •

edited by xylar

Loading

xylar commented Dec 10, 2022 •

edited

Loading

xylar Dec 10, 2022 •

edited

Loading

maresb commented Dec 11, 2022 •

edited

Loading

maresb commented Dec 11, 2022 •

edited

Loading