Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buf CLI and make use of the clean option #1187

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Aug 26, 2024

v1.36.0 of the buf CLI adds the top-level option clean to buf.gen.yaml. We can replace our npm scripts with this option.

@smaye81 smaye81 requested a review from timostamm August 26, 2024 15:52
smaye81 and others added 8 commits August 26, 2024 13:21
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@timostamm timostamm merged commit 86299a8 into main Aug 27, 2024
20 checks passed
@timostamm timostamm deleted the sayers/clean_cli branch August 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants