-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create container with environment variables #1499
Create container with environment variables #1499
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
- Coverage 34.18% 34.00% -0.18%
==========================================
Files 13 13
Lines 1135 1135
Branches 392 390 -2
==========================================
- Hits 388 386 -2
Misses 493 493
- Partials 254 256 +2 |
e10a06c
to
b4e18e1
Compare
097b686
to
2224dd6
Compare
/hold for #1498 |
Signed-off-by: Martin Michaelis <code@mgjm.de>
Signed-off-by: Martin Michaelis <code@mgjm.de>
2224dd6
to
97d6b46
Compare
97d6b46
to
9be4262
Compare
Closed by accident (during rebase), and #1498 is merged now |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mgjm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add an option to pass environment variables to the OCI runtime.
Update: I extended this PR to also add the same option to
ExecSyncConfig
.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This PR depends on #1498 for the new
TextTextMap
capnp type and helper functions.b4e18e1 is the new commit in this PR
2224dd6 does the same for
ExecSync
Does this PR introduce a user-facing change?