Add per command cgroup manager option #1504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The
CgroupManager
option is only used insidecreateContainer
andexecSyncContainer
.This PR moves this option from the global config to the respective command options.
For backwards compatibility the go client keeps the global option and only uses the per command option if the global
ConmonServerConfig.CgroupManager
is set toCgroupManagerPerCommand
.This allows existing users like CRI-O to keep working with old and new conmon-rs servers and will allow new users like podman to use the per command option with new conmon-rs servers.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This PR depends on #1499 because capnp fields are numbered sequentially.MergedClippy complained about too many arguments to the
generate_create_args
andgenerate_exec_sync_args
functions. Therefore I moved the common arguments to the newGenerateRuntimeArgs
struct and implemented thecreate_args
andexec_sync_args
methods.Does this PR introduce a user-facing change?