Add support for OpenTelemetry tracing via OTLP #785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows using the GRPC endpoint of an OTLP exporter to export span-based telemetry data directly from conmon-rs.
Which issue(s) this PR fixes:
Fixes tokio-rs/tracing#481
Special notes for your reviewer:
Demo:
For usage with the current CRI-O
main
we have to manually force-enable tracing:Then we can give it a try:
Opening Jaeger UI on http://localhost:16686 does now show the conmonrs service:
And the spans contain the relevant information:
There seems to be a bug that spans are missing from the telemetry, which should be fixed before used in production:
open-telemetry/opentelemetry-rust#888, tokio-rs/tracing-opentelemetry#58
Does this PR introduce a user-facing change?