subscriber: fix buggy format with module disabled #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Dec 20, 2019
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jan 10, 2020
Added: - **fmt**: Public `FormattedFields::new` constructor (#478) - **fmt**: Added examples to `fmt::Layer` documentation (#510) - Documentation now shows what feature flags are required by each API item (#525) Fixed: - **fmt**: Missing space between timestamp and level (#480) - **fmt**: Incorrect formatting with `with_target(false)` (#481) - **fmt**: `fmt::SubscriberBuilder::init` not setting up `log` compatibility (#489) - **registry**: Spans exited out of order not being closed properly on exit (#509) - **registry**: Memory leak when spans are closed by a child span closing (#514) - **registry**: Spans closed by a child span closing not also closing _their_ parents (#514) - Compilation errors with `no-default-features` (#499, #500) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jan 11, 2020
* subscriber: prepare to release 0.2.0-alpha.3 ### Added - **fmt**: Public `FormattedFields::new` constructor (#478) - **fmt**: Added examples to `fmt::Layer` documentation (#510) - Documentation now shows what feature flags are required by each API item (#525) ### Fixed - **fmt**: Missing space between timestamp and level (#480) - **fmt**: Incorrect formatting with `with_target(false)` (#481) - **fmt**: `fmt::SubscriberBuilder::init` not setting up `log` compatibility (#489) - **registry**: Spans exited out of order not being closed properly on exit (#509) - **registry**: Memory leak when spans are closed by a child span closing (#514) - **registry**: Spans closed by a child span closing not also closing _their_ parents (#514) - Compilation errors with `no-default-features` (#499, #500) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #476