-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple --network flags for podman run/create #8410
Allow multiple --network flags for podman run/create #8410
Conversation
c30f849
to
667dff6
Compare
I'm not strictly opposed, but if we do this we need to be very sure the manpage makes it clear that this is only for multiple networks - I'm afraid of users thinking that |
Could we add a failure mode where the user did do |
The code LGTM, but share @mheon's thought on man page updates for this. |
agree |
667dff6
to
86f9fec
Compare
Updated. This is now the error.
I also removed the extra pod parsing logic. The invalid options are already handled in |
86f9fec
to
87a9273
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We allow a container to be connected to several cni networks but only if they are listed comma sperated. This is not intuitive for users especially since the flag parsing allows multiple string flags but only would take the last value. see: spf13/pflag#72 Also get rid of the extra parsing logic for pods. The invalid options are already handled by `pkg/specgen`. A test is added to prevent a future regression. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
87a9273
to
f441190
Compare
Tests are green. |
LGTM |
/lgtm |
We allow a container to be connected to several cni networks
but only if they are listed comma sperated. This is not intuitive
for users especially since the flag parsing allows multiple string
flags but only would take the last value. see: spf13/pflag#72
Also get rid of the extra parsing logic for pods. The invalid options
are already handled by
pkg/specgen
.A test is added to prevent a future regression.