Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple --network flags for podman run/create #8410

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Allow multiple --network flags for podman run/create #8410

merged 1 commit into from
Nov 21, 2020

Commits on Nov 20, 2020

  1. Allow multiple --network flags for podman run/create 

    We allow a container to be connected to several cni networks
but only if they are listed comma sperated. This is not intuitive
for users especially since the flag parsing allows multiple string
flags but only would take the last value. see: spf13/pflag#72

Also get rid of the extra parsing logic for pods. The invalid options
are already handled by `pkg/specgen`.

A test is added to prevent a future regression.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
    Paul Holzinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    f441190 View commit details
    Browse the repository at this point in the history