cmd/create: Replace deprecated github.com/briandowns/spinner API #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The src/go.sum file was updated with 'go mod tidy'. containers#1585
The src/go.sum file was updated with 'go mod tidy'. containers#1585
The src/go.sum file was updated with 'go mod tidy'. containers#1585
The src/go.sum file was updated with 'go mod tidy'. containers#1585
A new API was added to github.com/briandowns/spinner 1.23.0 to deprecate the io.Writer output in favour of a pointer to an os.File [1]. This new API enables the spinner to automatically detect whether the output is connected to a terminal or not, which is convenient. Commit 944b3ac already bumped the required github.com/briandowns/spinner version to 1.23.0, so take advantage of that. [1] github.com/briandowns/spinner commit 1445186377e2e283 briandowns/spinner@1445186377e2e283 briandowns/spinner#142 containers#1586
debarshiray
force-pushed
the
wip/rishi/src-cmd-create-spinnerWithWriterFile
branch
from
a972137
to
bb2cda1
Compare
debarshiray
deleted the
wip/rishi/src-cmd-create-spinnerWithWriterFile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new API was added to
github.com/briandowns/spinner1.23.0 to deprecatethe
io.Writeroutput in favour of a pointer to anos.File[1]. This newAPI enables the spinner to automatically detect whether the output is
connected to a terminal or not, which is convenient.
Commit 944b3ac already bumped the required
github.com/briandowns/spinnerversion to 1.23.0, so take advantage ofthat.
[1] github.com/briandowns/spinner commit 1445186377e2e283
briandowns/spinner@1445186377e2e283
briandowns/spinner#142