Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/create: Replace deprecated github.com/briandowns/spinner API #1586

Merged
merged 5 commits into from
Nov 2, 2024
Merged

cmd/create: Replace deprecated github.com/briandowns/spinner API #1586

merged 5 commits into from
Nov 2, 2024

Commits on Nov 1, 2024

  1. build: Bump github.com/briandowns/spinner to 1.21.0 

    The src/go.sum file was updated with 'go mod tidy'.

containers#1585
    @debarshiray
    debarshiray committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fda91a2 View commit details
    Browse the repository at this point in the history

  2. build: Bump github.com/briandowns/spinner to 1.22.0 

    The src/go.sum file was updated with 'go mod tidy'.

containers#1585
    @debarshiray
    debarshiray committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    baab11e View commit details
    Browse the repository at this point in the history

  3. build: Bump github.com/briandowns/spinner to 1.23.0 

    The src/go.sum file was updated with 'go mod tidy'.

containers#1585
    @debarshiray
    debarshiray committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    944b3ac View commit details
    Browse the repository at this point in the history

  4. build: Bump github.com/briandowns/spinner to 1.23.1 

    The src/go.sum file was updated with 'go mod tidy'.

containers#1585
    @debarshiray
    debarshiray committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    38ca815 View commit details
    Browse the repository at this point in the history

  5. cmd/create: Replace deprecated github.com/briandowns/spinner API 

    A new API was added to github.com/briandowns/spinner 1.23.0 to deprecate
the io.Writer output in favour of a pointer to an os.File [1].  This new
API enables the spinner to automatically detect whether the output is
connected to a terminal or not, which is convenient.

Commit 944b3ac already bumped the required
github.com/briandowns/spinner version to 1.23.0, so take advantage of
that.

[1] github.com/briandowns/spinner commit 1445186377e2e283
    briandowns/spinner@1445186377e2e283
    briandowns/spinner#142

containers#1586
    @debarshiray
    debarshiray committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    bb2cda1 View commit details
    Browse the repository at this point in the history